Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 11066123: Enable WebMediaPlayerMS only when ENABLE_WEBRTC is defined. (Closed)

Created:
8 years, 2 months ago by wjia(left Chromium)
Modified:
8 years, 2 months ago
Reviewers:
miket_OOO, jam, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Enable WebMediaPlayerMS only when ENABLE_WEBRTC is defined. Some platforms have gyp define enable_webrt=0. BUG=142988 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wjia(left Chromium)
Antoine, this patch is to fix platform with enable_webrtc set to 0.
8 years, 2 months ago (2012-10-11 17:25:04 UTC) #1
miket_OOO
LGTM. Thanks!
8 years, 2 months ago (2012-10-11 19:36:41 UTC) #2
jam
lgtm
8 years, 2 months ago (2012-10-11 20:22:24 UTC) #3
piman
8 years, 2 months ago (2012-10-12 16:47:13 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698