Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11066118: Implement committed physical memory stats for Linux. (Closed)

Created:
8 years, 2 months ago by alph
Modified:
8 years, 2 months ago
CC:
v8-dev, yurys, loislo
Visibility:
Public.

Description

Implement committed physical memory stats for Linux. The patch introduces CommittedPhysicalMemory function to the Heap class that reports committed *physical* memory acquired for the heap from the OS. It is important because some OSes may defer actual committment on e.g. first access to the region. So reporting just plain committed size led to various weird artifacts like showing V8 allocated memory higher than the whole process private size. BUG=v8:2191 Committed: https://code.google.com/p/v8/source/detail?r=12793

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -1 line) Patch
M include/v8.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/heap.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/platform.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-cygwin.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-freebsd.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-macos.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-openbsd.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/spaces.h View 1 8 chunks +25 lines, -1 line 0 comments Download
M src/spaces.cc View 1 6 chunks +48 lines, -0 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Michael, I've implemented the committed physical size approximation without use of mincore which happened to ...
8 years, 2 months ago (2012-10-11 13:17:23 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/11066118/diff/1/src/spaces.cc File src/spaces.cc (right): https://chromiumcodereview.appspot.com/11066118/diff/1/src/spaces.cc#newcode882 src/spaces.cc:882: MemoryChunk::UpdateHighWaterMark(allocation_info_.top); This function is called by PagedSpace::SlowAllocateRaw which uses ...
8 years, 2 months ago (2012-10-16 13:01:06 UTC) #2
alph
Thanks for the review. PTAL. P.S. Looks like I rebaselined the patch at some point ...
8 years, 2 months ago (2012-10-16 13:44:41 UTC) #3
Michael Starzinger
8 years, 2 months ago (2012-10-22 16:22:46 UTC) #4
LGTM. I'll land that for you.

Powered by Google App Engine
This is Rietveld 408576698