Issue 11066105: [NaCl SDK] nacl_mounts: wrap functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066105: [NaCl SDK] nacl_mounts: wrap functions. (Closed)

Created:
8 years, 2 months ago by binji

Modified:
8 years, 2 months ago

Reviewers:
noelallen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] nacl_mounts: wrap functions. BUG=122229 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162282

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : feedback #

Patch Set 5 : win fix #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1095 lines, -229 lines)			Patch
M	native_client_sdk/src/libraries/gtest/nacl_gtest_dummy_sys.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	native_client_sdk/src/libraries/gtest_ppapi/gtest_module.h	View	1 2	2 chunks	+4 lines, -11 lines	0 comments	Download
M	native_client_sdk/src/libraries/gtest_ppapi/gtest_module.cc	View	1 2	1 chunk	+3 lines, -19 lines	0 comments	Download
M	native_client_sdk/src/libraries/gtest_ppapi/library.dsc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_intercept.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_intercept.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap.h	View	1 2	1 chunk	+79 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap.cc	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_glibc.cc	View	1	1 chunk	+277 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_newlib.cc	View	1	1 chunk	+163 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_win.cc	View	1 2	1 chunk	+218 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/library.dsc	View	1 2	4 chunks	+12 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts_test/example.dsc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts_test/kernel_intercept_test.cc	View	1 2	1 chunk	+0 lines, -189 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts_test/kernel_proxy_mock.h	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download
A	native_client_sdk/src/libraries/nacl_mounts_test/kernel_wrap_test.cc	View	1 2 3 4	1 chunk	+257 lines, -0 lines	0 comments	Download
A +	native_client_sdk/src/libraries/nacl_mounts_test/module.cc	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

noelallen1

8 years, 2 months ago (2012-10-16 20:22:57 UTC) #2

One nit, otherwise LGTM

http://codereview.chromium.org/11066105/diff/6001/native_client_sdk/src/libra...
File native_client_sdk/src/libraries/nacl_mounts_test/kernel_wrap_test.cc
(right):

http://codereview.chromium.org/11066105/diff/6001/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_mounts_test/kernel_wrap_test.cc:147: #if 0
Did you mean to leave this here?

Expand Messages | Collapse Messages