Fix a regression which caused Chrome to always launch in Windows 8 mode on tablets. This was caused…

Fix a regression which caused Chrome to always launch in Windows 8 mode on tablets. This was caused by 
my change to fix bug  http://code.google.com/p/chromium/issues/detail?id=153318 which attempted to 
activate chrome in Windows 8 mode if the previous launch mode was Windows 8.

We also don't attempt to activate into metro if the command line contains the uninstall switch.

BUG=154663
R=sky
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161217

[sky, 2012-10-10 20:54:46]

LGTM

[sky, 2012-10-10 22:05:16]

SLGTM

[gab, 2012-10-11 01:55:48]

See discussion inline.

https://codereview.chromium.org/11066102/diff/1003/chrome/browser/process_sin...
File chrome/browser/process_singleton_win.cc (right):

https://codereview.chromium.org/11066102/diff/1003/chrome/browser/process_sin...
chrome/browser/process_singleton_win.cc:205: if
(CommandLine::ForCurrentProcess()->HasSwitch(switches::kUninstall))
I feel this is a special case hiding a bigger problem (i.e. there are other
short-lived switches for chrome.exe which are likely broken in the same way
now).

https://codereview.chromium.org/11066102/diff/1003/chrome/browser/process_sin...
chrome/browser/process_singleton_win.cc:214: if
(reg_key.ReadValueDW(chrome::kLaunchModeValue, &reg_value)
Isn't it simpler to have a single if for the logic here and above? i.e.:

if (reg_key.Create(...) == ERROR_SUCCESS &&
    reg_key.ReadValueDW(...) == ERROR_SUCCESS) {
  return reg_value == 1;
}