Tentatively turn on WebMediaPlayerMS by default.

Tentatively turn on WebMediaPlayerMS by default.

WebMediaPlayerMS can be disabled by using "--disable-web-media-player-ms"
Create a static function in MediaStreamImpl for checking whether a URL is media stream. This can save some overhead in render_view_impl.cc.

BUG=142988
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161230

[scherkus (not reviewing), 2012-10-10 18:01:43]

Fix CL description (capitalization, etc...)

Instead of removing the flag, you'll want this to be a disabling flag so it's
easier to do A/B testing and triage bugs

[wjia(left Chromium), 2012-10-10 21:05:21]

Thanks! PTAL.

[scherkus (not reviewing), 2012-10-10 21:31:24]

lgtm

thanks for tackling this wei -- great stuff :)

[wjia(left Chromium), 2012-10-10 22:04:14]

+piman@ for owner's stamp.

[piman, 2012-10-10 22:26:42]

https://codereview.chromium.org/11066101/diff/2002/content/renderer/render_vi...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11066101/diff/2002/content/renderer/render_vi...
content/renderer/render_view_impl.cc:2653: EnsureMediaStreamImpl();
So, when I originally reviewed this, one of my concern is that this call may be
heavy (creating threads etc.), yet you're paying for it whether or not you will
be creating a WebMediaPlayerMS.
Could it be possible to extract whatever you need for just querying
IsMediaStream(url) so that we don't have to pay that cost?

[wjia(left Chromium), 2012-10-10 23:15:11]

PTAL.

https://codereview.chromium.org/11066101/diff/2002/content/renderer/render_vi...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/11066101/diff/2002/content/renderer/render_vi...
content/renderer/render_view_impl.cc:2653: EnsureMediaStreamImpl();
On 2012/10/10 22:26:43, piman wrote:
> So, when I originally reviewed this, one of my concern is that this call may
be
> heavy (creating threads etc.), yet you're paying for it whether or not you
will
> be creating a WebMediaPlayerMS.
> Could it be possible to extract whatever you need for just querying
> IsMediaStream(url) so that we don't have to pay that cost?

yeah, you are right. I added a static function in MediaStreamImpl to remove the
overhead of creating an instance.

[piman, 2012-10-10 23:24:58]

Awesome, LGTM, thanks!