Issue 11066098: Fix a test which uses the RenderViewTest harness running in unit_test binaries. This gives an asser…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066098: Fix a test which uses the RenderViewTest harness running in unit_test binaries. This gives an asser… (Closed)

Created:
8 years, 2 months ago by jam

Modified:
8 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix a test which uses the RenderViewTest harness running in unit_test binaries. This gives an assert in WebKit in debug builds because WebKit is only supposed to be initialized once. The fix is to separate the test from the harness. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161202

Patch Set 1 : #

Patch Set 2 : make sure ResourceBundle is initialized in render view tests #

Patch Set 3 : fix deps #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -235 lines)			Patch
M	chrome/renderer/safe_browsing/phishing_thumbnailer_browsertest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
MM	content/public/test/DEPS	View	1 2	1 chunk	+9 lines, -8 lines	0 comments	Download
M	content/public/test/render_view_test.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
D	content/public/test/render_widget_browsertest.h	View	1	1 chunk	+0 lines, -60 lines	0 comments	Download
D	content/public/test/render_widget_browsertest.cc	View	1	1 chunk	+0 lines, -155 lines	0 comments	Download
A +	content/public/test/render_widget_test.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/public/test/render_widget_test.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
A	content/renderer/render_widget_browsertest.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages