Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 11066092: [Android] Resource files for upstreaming content detection and ChromeBrowserProvider tests. (Closed)

Created:
8 years, 2 months ago by Leandro Graciá Gil
Modified:
8 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] Resource files for upstreaming content detection and ChromeBrowserProvider tests. BUG=125390, 138755 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, --4 lines) Patch
A + chrome/test/data/android/device_files/provider/icon1.png View Binary file 0 comments Download
A chrome/test/data/android/device_files/provider/icon2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/android/device_files/provider/icon3.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/shell/android/res/drawable/ic_menu_search_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/shell/android/res/drawable/ic_menu_share_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
lgtm
8 years, 2 months ago (2012-10-10 00:50:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11066092/1
8 years, 2 months ago (2012-10-10 00:52:15 UTC) #2
commit-bot: I haz the power
Can't process patch for file chrome/test/data/android/device_files/provider/icon1.png. Binary file support is temporarilly disabled due to a ...
8 years, 2 months ago (2012-10-10 00:52:16 UTC) #3
Leandro Graciá Gil
I wonder what part of NOTRY=true this doesn't understand... Geez... On 2012/10/10 00:52:16, I haz ...
8 years, 2 months ago (2012-10-10 00:53:01 UTC) #4
Yaron
On 2012/10/10 00:53:01, Leandro Graciá Gil wrote: > I wonder what part of NOTRY=true this ...
8 years, 2 months ago (2012-10-10 00:59:06 UTC) #5
Leandro Graciá Gil
8 years, 2 months ago (2012-10-10 01:00:15 UTC) #6
On 2012/10/10 00:59:06, Yaron wrote:
> On 2012/10/10 00:53:01, Leandro Graciá Gil wrote:
> > I wonder what part of NOTRY=true this doesn't understand... Geez...
> > 
> > On 2012/10/10 00:52:16, I haz the power (commit-bot) wrote:
> > > Can't process patch for file
> > > chrome/test/data/android/device_files/provider/icon1.png.
> > > Binary file support is temporarilly disabled due to a bug. Please commit
> > blindly
> > > the binary files first then commit the source change as a separate CL.
Sorry
> > for
> > > the annoyance.
> 
> just dcommit

As soon as the tree opens.

Powered by Google App Engine
This is Rietveld 408576698