Browser Plugin: Update Guest WebContents Visibility on BrowserPlugin Visiblity Change.

content/browser/browser_plugin/browser_plugin_host_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/singleton.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/browser_plugin/browser_plugin_host_factory.h"
@@ skipping 398 matching lines @@
   EXPECT_EQ(expected_title, actual_title);
   LOG(INFO) << "Done navigating to second page";
 
   TestBrowserPluginEmbedder* test_embedder_after_nav =
       static_cast<TestBrowserPluginEmbedder*>(
           embedder_web_contents->GetBrowserPluginEmbedder());
   // Embedder must not change in web_contents.
   ASSERT_EQ(test_embedder_after_nav, test_embedder());
 }
 
-IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, VisibilityChanged) {
+// This test verifies that hiding the embedder also hides the guest.
+IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, EmbedderVisibilityChanged) {

[Charlie Reis, 2012/10/05 00:33:18]

I think these names are backwards, right?

[Fady Samuel, 2012/10/05 15:22:07]

Wow, you're right, I don't know how that happened :S Done.

   const char* kEmbedderURL = "files/browser_plugin_embedder.html";
   StartBrowserPluginTest(kEmbedderURL, kHTMLForGuest, true, "");
 
-  // Wait for the guest to send an UpdateRectMsg, meaning it is ready.
-  test_guest()->WaitForUpdateRectMsg();
+  // Hide the Browser Plugin.
+  RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
+      test_embedder()->web_contents()->GetRenderViewHost());
+  rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16(
+      "document.getElementById('plugin').style.visibility = 'hidden'"));
+
+  // Make sure that the guest is hidden.
+  test_guest()->WaitUntilHidden();
+}
+
+IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, BrowserPluginVisibilityChanged) {
+  const char* kEmbedderURL = "files/browser_plugin_embedder.html";
+  StartBrowserPluginTest(kEmbedderURL, kHTMLForGuest, true, "");
 
   // Hide the embedder.
   test_embedder()->web_contents()->WasHidden();
 
   // Make sure that hiding the embedder also hides the guest.
   test_guest()->WaitUntilHidden();
 }
 
 // This test verifies that calling the reload method reloads the guest.
 IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, ReloadGuest) {
@@ skipping 217 matching lines @@
       test_embedder()->web_contents()->GetRenderViewHost());
   GURL test_url = test_server()->GetURL("close-socket");
   rvh->ExecuteJavascriptAndGetValue(string16(), ASCIIToUTF16(
       StringPrintf("SetSrc('%s');", test_url.spec().c_str())));
 
   string16 actual_title = title_watcher.WaitAndGetTitle();
   EXPECT_EQ(expected_title, actual_title);
 }
 
 }  // namespace content