Browser Plugin: Update Guest WebContents Visibility on BrowserPlugin Visiblity Change.

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/string_util.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_helper.h"
@@ skipping 25 matching lines @@
                                        RenderViewHost* render_view_host)
     : WebContentsObserver(web_contents),
       embedder_render_process_host_(NULL),
       instance_id_(instance_id),
 #if defined(OS_WIN)
       damage_buffer_size_(0),
 #endif
       damage_buffer_scale_factor_(1.0f),
       pending_update_counter_(0),
       guest_hang_timeout_(
-          base::TimeDelta::FromMilliseconds(kGuestHangTimeoutMs)) {
+          base::TimeDelta::FromMilliseconds(kGuestHangTimeoutMs)),
+      visible_(true) {
   DCHECK(web_contents);
   // |render_view_host| manages the ownership of this BrowserPluginGuestHelper.
   new BrowserPluginGuestHelper(this, render_view_host);
 }
 
 BrowserPluginGuest::~BrowserPluginGuest() {
 }
 
 // static
 BrowserPluginGuest* BrowserPluginGuest::Create(
@@ skipping 34 matching lines @@
       web_contents()->GetRenderProcessHost()->GetHandle();
   base::KillProcess(process_handle, RESULT_CODE_HUNG, false);
   RecordAction(UserMetricsAction("BrowserPlugin.Guest.Hung"));
 }
 
 void BrowserPluginGuest::SetIsAcceptingTouchEvents(bool accept) {
   SendMessageToEmbedder(
       new BrowserPluginMsg_ShouldAcceptTouchEvents(instance_id(), accept));
 }
 
+void BrowserPluginGuest::SetVisibility(bool embedder_visible, bool visible) {
+  visible_ = visible;
+  if (embedder_visible && visible)
+    web_contents()->WasShown();
+  else
+    web_contents()->WasHidden();

[Charlie Reis, 2012/10/05 00:33:18]

Just to be clear, does this notify the guest renderer process so that it
realizes it is hidden/shown?  Maybe you can mention that in the comment in
browser_plugin_guest.h.

[Fady Samuel, 2012/10/05 15:22:07]

Done.

+}
+
 WebContents* BrowserPluginGuest::GetWebContents() {
   return web_contents();
 }
 
 void BrowserPluginGuest::Terminate() {
   RecordAction(UserMetricsAction("BrowserPlugin.Guest.Terminate"));
   base::ProcessHandle process_handle =
       web_contents()->GetRenderProcessHost()->GetHandle();
   base::KillProcess(process_handle, RESULT_CODE_KILLED, false);
 }
@@ skipping 256 matching lines @@
       break;
   }
 }
 
 void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
   DCHECK(embedder_render_process_host());
   embedder_render_process_host()->Send(msg);
 }
 
 }  // namespace content