Issue 11066025: Merge 159612 - Temporary fix bug in disabling sync for default apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066025: Merge 159612 - Temporary fix bug in disabling sync for default apps (Closed)

Created:
8 years, 2 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 2 months ago

Reviewers:
Gaurav

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

More Reviews

Description

Merge 159612 - Temporary fix bug in disabling sync for default apps We added a new creation_flag for default apps was_installed_by_default, but every time we add a new creation_flag, we need to update the installedLoader as it does not directly pick the creation_flags but re-creates them through other preferences. This is temporary fix for M-23 branch. A more fundamental fix is 10977048 BUG=152582 Review URL: https://chromiumcodereview.appspot.com/11034009 TBR=grv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160208

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/extensions/installed_loader.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/10/04 20:05:48, Mihai Parparita wrote:

LGTM

Expand Messages | Collapse Messages