Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11066021: add wrapper to make GYP_PARALLEL=1 work (Closed)

Created:
8 years, 2 months ago by scottmg
Modified:
8 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Visibility:
Public.

Description

add wrapper to make GYP_PARALLEL=1 work for build\gyp_chromium This is a workaround for multiprocessing on Windows. Importing in Python on Windows doesn't search for imports that don't end in .py (and aren't directories with an __init__.py). So, add this wrapper to avoid having people change their command line to add a .py when running gyp_chromium. R=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A build/gyp_chromium.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 2 months ago (2012-10-04 17:11:01 UTC) #1
dmazzoni
8 years, 2 months ago (2012-10-04 17:16:53 UTC) #2
lgtm

Nice! Mike Wittman had just identified the same root cause, but I was figuring I
might have to do the opposite (rename gyp_chromium -> gyp_chromium.py, update a
lot of stuff...) - this is much simpler!

Powered by Google App Engine
This is Rietveld 408576698