Finish implementation of controlled setting indicator

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.internet', function() {
   var OptionsPage = options.OptionsPage;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var IPAddressField = options.internet.IPAddressField;
 
   /**
@@ skipping 957 matching lines @@
       detailsPage.vpn = true;
       detailsPage.ethernet = false;
       detailsPage.cellular = false;
       detailsPage.gsm = false;
       $('inet-service-name').textContent = data.service_name;
       $('inet-provider-type').textContent = data.provider_type;
       $('inet-username').textContent = data.username;
       var inetServerHostname = $('inet-server-hostname');
       inetServerHostname.value = data.serverHostname.value;
       inetServerHostname.resetHandler = function() {
-        inetServerHostname.value = data.serverHostname.default;
+        inetServerHostname.value = data.serverHostname.recommendedValue;
+        OptionsPage.hideBubble();
       };
     } else {
       OptionsPage.showTab($('internet-nav-tab'));
       detailsPage.ethernet = true;
       detailsPage.wireless = false;
       detailsPage.wimax = false;
       detailsPage.vpn = false;
       detailsPage.cellular = false;
       detailsPage.gsm = false;
     }
 
     // Update controlled option indicators.
     indicators = cr.doc.querySelectorAll(
         '#details-internet-page .controlled-setting-indicator');
     for (var i = 0; i < indicators.length; i++) {
-      var dataProperty = indicators[i].getAttribute('data');
-      if (dataProperty && data[dataProperty]) {
-        var controlledBy = data[dataProperty].controlledBy;
-        if (controlledBy) {
-          indicators[i].controlledBy = controlledBy;
-          var forElement = $(indicators[i].getAttribute('for'));
-          if (forElement) {
-            forElement.disabled = controlledBy != 'recommended';
-            if (forElement.type == 'radio' && !forElement.checked)
-              indicators[i].hidden = true;
-            if (forElement.resetHandler)
-              indicators[i].resetHandler = forElement.resetHandler;
-          }
-        } else {
-          indicators[i].controlledBy = null;
+      var propName = indicators[i].getAttribute('data');
+      if (propName && data[propName]) {

[James Hawkins, 2012/10/04 16:16:51]

Optional nit: Save a lot of indentation by continuing early on the reverse
condition.

[bartfab (slow), 2012/10/04 18:55:39]

Done.

+        var propData = data[propName];
+        // Create a synthetic pref change event decorated as
+        // CoreOptionsHandler::CreateValueForPref() does.
+        var event = new cr.Event(name);
+        event.value = {
+          value: propData.value,
+          controlledBy: propData.controlledBy,
+          recommendedValue: propData.recommendedValue,
+        };
+        indicators[i].handlePrefChange(event);
+        var forElement = $(indicators[i].getAttribute('for'));
+        if (forElement) {
+          forElement.disabled = propData.controlledBy == 'policy';
+          if (forElement.resetHandler)
+            indicators[i].resetHandler = forElement.resetHandler;
         }
       }
     }
 
     detailsPage.updateControls();
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     OptionsPage.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });