Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11066014: Revert revision 13230 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 13230)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -469,10 +469,6 @@
} else if (configuration['runtime'] == 'd8') {
var d8 = TestUtils.d8FileName(configuration);
commands.add(new Command(d8, ['$tempDir/out.js']));
- } else if (configuration['runtime'] == 'jsshell') {
- var jsshell = TestUtils.jsshellFileName(configuration);
- var environment = TestUtils.jsshellEnvironment(configuration);
- commands.add(new Command(jsshell, ['$tempDir/out.js'], environment));
}
return commands;
@@ -1271,10 +1267,7 @@
static String executableSuffix(String executable) {
if (Platform.operatingSystem == 'windows') {
- if (executable == 'd8' ||
- executable == 'vm' ||
- executable == 'none' ||
- executable == 'jsshell') {
+ if (executable == 'd8' || executable == 'vm' || executable == 'none') {
return '.exe';
} else {
return '.bat';
@@ -1405,26 +1398,6 @@
return args;
}
- static String jsshellDir(Map configuration) {
- var base = dartDir();
- return '$base/third_party/firefox_jsshell/${configuration['system']}';
- }
-
- static String jsshellFileName(Map configuration) {
- var executableSuffix = executableSuffix('jsshell');
- var executable = 'js$executableSuffix';
- var jsshellDir = jsshellDir(configuration);
- return '$jsshellDir/$executable';
- }
-
- static Map<String, String> jsshellEnvironment(Map configuration) {
- if (configuration['system'] == 'linux') {
- var jsshellDir = jsshellDir(configuration);
- return {'LD_LIBRARY_PATH': jsshellDir};
- }
- return {};
- }
-
static bool isBrowserRuntime(String runtime) => Contains(
runtime,
const <String>['drt',
@@ -1434,10 +1407,6 @@
'opera',
'chrome',
'ff']);
-
- static bool isJsCommandLineRuntime(String runtime) =>
- Contains(runtime, const <String>['d8', 'jsshell']);
-
}
class SummaryReport {
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698