Support output of input types (email, tel, time, date).

Support output of input types (email, tel, time, date).

Time and date appear as a series of spin buttons with their help attributes containing their label text. Include $help in the default output rule.
Add a condition to substitute a proper role message string for role textField.

TEST=OutputE2ETest.*

Committed: https://crrev.com/9ba360de4cee36a01a5f5b3b7c5cd6e65eb6748b
Cr-Commit-Position: refs/heads/master@{#326885}

[David Tseng, 2015-04-23 18:21:47]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-04-23 18:26:50]

This change and the one to fix audio/video controls feels like we're putting the
logic in the wrong place.

I think the output rules should just say $name, and we should do a bit of
preprocessing to get the correct name from a few different fields.

When Alice and I finish implementing the new name calculation code, you won't
have to do any preprocessing. name will always contain the primary name, and
description will only contain secondary text, which we can maybe queue up to
speak after a short delay or something like that

[David Tseng, 2015-04-23 18:32:23]

This change actually tries to get the correct role not the name for at
least the types tel, email.



It does try to get the help text as the "name" for the date/time cases.

Are you and or Alice fixing the first issue? (e.g. with subroles or some
other solution).

On Thu, Apr 23, 2015 at 11:21 AM, <dtseng@chromium.org> wrote:

> Reviewers: dmazzoni,
>
> Description:
> Support output of input types (email, tel, time, date).
>
> Time and date appear as a series of spin buttons with their help attributes
> containing their label text. Include $help in the default output rule.
> Add a condition to substitute a proper role message string for role
> textField.
>
> TEST=OutputE2ETest.*
>
> Please review this at https://codereview.chromium.org/1106583003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+7, -1 lines):
>   M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
>
>
> Index:
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> diff --git
> a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> index
>
f19913fb28a39a92d5448ed93be4b16be93317c1..36871bfb7247841181b325dafe09afe8440ce7a5
> 100644
> ---
> a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> +++
> b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> @@ -156,7 +156,7 @@ Output.STATE_INFO_ = {
>  Output.RULES = {
>    navigate: {
>      'default': {
> -      speak: '$name $value $role',
> +      speak: '$name $value $role $help',
>        braille: ''
>      },
>      alert: {
> @@ -215,6 +215,12 @@ Output.RULES = {
>      tab: {
>        speak: '@describe_tab($name)'
>      },
> +    textField: {
> +      speak: '$name $value $if(' +
> +          '$textInputType, @input_type_+$textInputType, @input_type_text)
> ' +
> +          '$earcon(EDITABLE_TEXT)',
> +      braille: ''
> +    },
>      toolbar: {
>        enter: '$name $role'
>      },
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-04-23 18:34:54]

Sorry, I meant the $help part.

The rest is fine. Yes, I'd like to look into roles / role descriptions for
these, but I'm not sure we have a plan yet.

[David Tseng, 2015-04-23 18:38:03]

On 2015/04/23 18:34:54, dmazzoni wrote:
> Sorry, I meant the $help part.
> 
> The rest is fine. Yes, I'd like to look into roles / role descriptions for
> these, but I'm not sure we have a plan yet.

So, the $help goes in the default output rule (which also tries $name). The
assumption, at least from the screen reader end, is that both can be present
right? Is the plain to get rid of the help attribute?

[dmazzoni, 2015-04-23 21:39:24]

lgtm

Yes, the plan is to get rid of help. Eventually you'll only use name, and
optionally description only for secondary info.

How about "$name $description $help" for almost everything, and maybe include
$placeholder for editable text, too?

I'm fine with just including these fields in all output formatting rules where
they make sense - I just don't want $description or $help in one output rule and
not others because there's no logical reason for that.

lgtm with this change.

[David Tseng, 2015-04-24 20:40:48]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2015-04-24 20:40:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1106583003/#ps20001
(title: "Rebase and expand tests.")

[commit-bot: I haz the power, 2015-04-24 20:41:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106583003/20001

[commit-bot: I haz the power, 2015-04-24 20:45:46]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[David Tseng, 2015-04-24 20:45:58]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2015-04-24 20:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1106583003/#ps40001
(title: "Exited")

[commit-bot: I haz the power, 2015-04-24 20:47:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106583003/40001

[commit-bot: I haz the power, 2015-04-24 20:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 20:51:13]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[David Tseng, 2015-04-24 21:08:21]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2015-04-24 21:08:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1106583003/#ps50004
(title: "Rebased.")

[commit-bot: I haz the power, 2015-04-24 21:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106583003/50004

[commit-bot: I haz the power, 2015-04-24 21:42:09]

Committed patchset #4 (id:50004)

[commit-bot: I haz the power, 2015-04-24 21:44:16]

Patchset 4 (id:??) landed as
https://crrev.com/9ba360de4cee36a01a5f5b3b7c5cd6e65eb6748b
Cr-Commit-Position: refs/heads/master@{#326885}