Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1106573002: [Android] Fix checksum handling when md5sum generates unexpected output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index 3f56e6d99f90007caf457e5eb3fde6b608afbecf..ccc0e728602042a8d5c8efeeef4889b20bfe6304 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -335,7 +335,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
with open(pickle_path, 'r') as pickle_file:
pickle_data = pickle.loads(pickle_file.read())
- jar_md5, _ = md5sum.CalculateHostMd5Sums(jar_path)[0]
+ jar_md5 = md5sum.CalculateHostMd5Sums(jar_path)[jar_path]
perezju 2015/04/24 08:06:32 This usage seems pretty common. Wondering if we sh
jbudorick 2015/04/24 13:56:36 It only seems common because our instrumentation c
try:
if pickle_data['VERSION'] != _PICKLE_FORMAT_VERSION:
@@ -377,7 +377,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
if is_test_class(c)]
def _SaveTestsToPickle(self, pickle_path, jar_path, tests):
- jar_md5, _ = md5sum.CalculateHostMd5Sums(jar_path)[0]
+ jar_md5 = md5sum.CalculateHostMd5Sums(jar_path)[jar_path]
pickle_data = {
'VERSION': _PICKLE_FORMAT_VERSION,
'JAR_MD5SUM': jar_md5,

Powered by Google App Engine
This is Rietveld 408576698