Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1106533003: Update {virtual,override} to follow C++11 style in chrome_elf. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in chrome_elf. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/5c1d060ed293f8c882e1ba82c1c10c743167d0b5 Cr-Commit-Position: refs/heads/master@{#326454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome_elf/chrome_elf_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/create_file/chrome_create_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/ntdll_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-22 21:09:36 UTC) #2
Cait (Slow)
lgtm
5 years, 8 months ago (2015-04-23 00:03:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106533003/1
5 years, 8 months ago (2015-04-23 04:39:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 04:43:38 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 04:45:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1d060ed293f8c882e1ba82c1c10c743167d0b5
Cr-Commit-Position: refs/heads/master@{#326454}

Powered by Google App Engine
This is Rietveld 408576698