Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11065042: Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/html/scripts/generator.py ('K') | « lib/html/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index d02c65a70b73e5ca9767725b22014d8a919a31ac..7ada78090d80a9f0aa726ec0d62609ded5b3174f 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -240,9 +240,9 @@ class HtmlDartInterfaceGenerator(object):
self._backend.GenerateCallback(info)
def GenerateInterface(self):
+ interface_type_info = self._type_registry.TypeInfo(self._interface.id)
if (not self._interface.id in _merged_html_interfaces and
- # Don't re-generate types that have been converted to native dart types.
- self._html_interface_name not in nativified_classes):
+ interface_type_info.has_generated_interface()):
interface_emitter = self._library_emitter.FileEmitter(
self._html_interface_name)
else:
@@ -330,8 +330,6 @@ class HtmlDartInterfaceGenerator(object):
if self._backend.HasImplementation():
if not self._interface.id in _merged_html_interfaces:
name = self._html_interface_name
- if self._html_interface_name in nativified_classes:
- name = nativified_classes[self._html_interface_name]
basename = '%sImpl' % name
else:
basename = '%sImpl_Merged' % self._html_interface_name
@@ -612,10 +610,7 @@ class Dart2JSBackend(object):
return True
def _ImplClassName(self, type_name):
- name = type_name
- if type_name in nativified_classes:
- name = nativified_classes[type_name]
- return '_%sImpl' % name
+ return '_%sImpl' % type_name
def GenerateCallback(self, info):
pass
@@ -629,9 +624,6 @@ class Dart2JSBackend(object):
return None
if IsPureInterface(supertype):
return None
- elif supertype == 'NodeList':
- # Special case as NodeList gets converted to List<Node>.
- return '_NodeListImpl'
return self._type_registry.TypeInfo(supertype).implementation_name()
def AdditionalImplementedInterfaces(self):
« lib/html/scripts/generator.py ('K') | « lib/html/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698