Chromium Code Reviews
Help | Chromium Project | Sign in
(16)

Issue 11065037: fix the broeken audio for webrtc for precise (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by no longer working on chromium
Modified:
2 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

It seems PcmReadi() is often gives out more than 1 packets and this destroy the our scheduling for recording. BUG=153505 TEST=apprtc.appspot.com?debug=loopback, listen to the audio. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160661

Patch Set 1 #

Patch Set 2 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/audio/linux/alsa_input.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
no longer working on chromium
Hi Andrew, Could you please take a quick look at this? I need to merge ...
2 years, 5 months ago (2012-10-05 15:42:36 UTC) #1
DaleCurtis
Andrew is out travelling. Won't having PcmReadi provide multiple packets on a regular basis and ...
2 years, 5 months ago (2012-10-05 17:25:39 UTC) #2
xians2
On 2012/10/05 17:25:39, DaleCurtis wrote: > Andrew is out travelling. > > Won't having PcmReadi ...
2 years, 5 months ago (2012-10-05 19:26:05 UTC) #3
DaleCurtis
Thanks for the explanation Xians. LGTM!
2 years, 5 months ago (2012-10-05 19:26:56 UTC) #4
no longer working on chromium
On 2012/10/05 19:26:56, DaleCurtis wrote: > Thanks for the explanation Xians. LGTM! Thanks Dale. FYI, ...
2 years, 5 months ago (2012-10-06 21:49:28 UTC) #5
I haz the power (commit-bot)
2 years, 5 months ago (2012-10-06 21:49:43 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted