Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac.mm

Issue 1106453002: Fixed app launcher crashing trying to load guest profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows compile. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_mac.mm
diff --git a/chrome/browser/ui/app_list/app_list_service_mac.mm b/chrome/browser/ui/app_list/app_list_service_mac.mm
index f33787952a5cf644c7bc20e3b115a7bff42d029e..0e8dd2970ecbd20d1e45d9db261036550d49a7a5 100644
--- a/chrome/browser/ui/app_list/app_list_service_mac.mm
+++ b/chrome/browser/ui/app_list/app_list_service_mac.mm
@@ -346,6 +346,12 @@ void AppListServiceMac::Init(Profile* initial_profile) {
void AppListServiceMac::InitWithProfilePath(
Profile* initial_profile,
const base::FilePath& profile_path) {
+ // App list profiles should not be off-the-record. It is currently possible to
+ // get here in an off-the-record profile via the Web Store
+ // (http://crbug.com/416380).
+ // TODO(mgiuca): DCHECK that requested_profile->IsOffTheRecord() and
+ // requested_profile->IsGuestSession() are false, once that is resolved.
+
// On Mac, Init() is called multiple times for a process: any time there is no
// browser window open and a new window is opened, and during process startup
// to handle the silent launch case (e.g. for app shims). In the startup case,
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_impl.cc ('k') | chrome/browser/ui/app_list/app_list_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698