Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1106443002: Fix serialization of alias_for properties (Closed)

Created:
5 years, 8 months ago by Timothy Loh
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@p7
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix serialization of alias_for properties This fixes transition and will-change to properly serialize alias_for properties instead of crashing. BUG=410112, 479441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194351

Patch Set 1 #

Patch Set 2 : fix :| #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M LayoutTests/transitions/transitions-parsing.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/transitions/transitions-parsing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/build/scripts/make_css_property_names.py View 1 2 2 chunks +13 lines, -15 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Timothy Loh
..oops :|
5 years, 8 months ago (2015-04-22 04:42:05 UTC) #2
alancutter (OOO until 2018)
lgtm with nit. https://codereview.chromium.org/1106443002/diff/20001/Source/build/scripts/make_css_property_names.py File Source/build/scripts/make_css_property_names.py (right): https://codereview.chromium.org/1106443002/diff/20001/Source/build/scripts/make_css_property_names.py#newcode209 Source/build/scripts/make_css_property_names.py:209: 'property_name_strings': property_name_strings, It would be easier ...
5 years, 8 months ago (2015-04-24 02:37:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106443002/40001
5 years, 8 months ago (2015-04-24 04:53:41 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194351
5 years, 8 months ago (2015-04-24 06:11:09 UTC) #7
tkent
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1081033005/ by tkent@chromium.org. ...
5 years, 8 months ago (2015-04-24 09:46:20 UTC) #8
tkent
5 years, 8 months ago (2015-04-24 09:53:33 UTC) #9
Message was sent while issue was closed. 
On 2015/04/24 09:46:20, tkent wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1081033005/ by mailto:tkent@chromium.org.
> 
> The reason for reverting is: Broke multiple tests on Windows XP.
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/18565
> 
> fast/css/getComputedStyle/computed-style-without-renderer.html
> fast/css/getComputedStyle/computed-style.html
> svg/css/getComputedStyle-basic.xhtml
> transforms/webkit-perspective-parsing.html
> transitions/unprefixed-perspective.html
> transitions/unprefixed-transform.html
> virtual/stable/webexposed/css-properties-as-js-properties.html
> virtual/threaded/transitions/unprefixed-perspective.html
> virtual/threaded/transitions/unprefixed-transform.html
> webexposed/css-properties-as-js-properties.html
> .

I'm sorry, it was a false alarm.  I'll re-land.

Powered by Google App Engine
This is Rietveld 408576698