gin/shell/gin_main.cc - Issue 1106393002: gin: Use V8 Maybe APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/shell/gin_main.cc

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/shell/gin_main.cc

diff --git a/gin/shell/gin_main.cc b/gin/shell/gin_main.cc

index d3bab721bebd82aa0d0741863a1d859c6919bab1..62143c9926f5a609ff95c2c3ef593a351df4925f 100644

--- a/gin/shell/gin_main.cc

+++ b/gin/shell/gin_main.cc

@@ -75,7 +75,9 @@ int main(int argc, char** argv) {

{

gin::Runner::Scope scope(&runner);

- v8::V8::SetCaptureStackTraceForUncaughtExceptions(true);

+ runner.GetContextHolder()

+ ->isolate()

+ ->SetCaptureStackTraceForUncaughtExceptions(true);

}

base::CommandLine::StringVector args =

« no previous file with comments | « gin/object_template_builder.cc ('k') | gin/shell_runner.cc » ('j') | no next file with comments »