gin/arguments.h - Issue 1106393002: gin: Use V8 Maybe APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/arguments.h

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/arguments.h

diff --git a/gin/arguments.h b/gin/arguments.h

index 4ac38a7ef8f95fab785a2b80d62cde5210bfc21a..1affa2c8acb1251a67f013f8f503679472b0fa22 100644

--- a/gin/arguments.h

+++ b/gin/arguments.h

@@ -69,7 +69,10 @@ class GIN_EXPORT Arguments {

template<typename T>

void Return(T val) {

- info_->GetReturnValue().Set(ConvertToV8(isolate_, val));

+ v8::Local<v8::Value> v8_value;

+ if (!TryConvertToV8(isolate_, val, &v8_value))

+ return;

+ info_->GetReturnValue().Set(v8_value);

}

v8::Local<v8::Value> PeekNext() const;

« no previous file with comments | « no previous file | gin/converter.h » ('j') | no next file with comments »