Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/try_catch.h

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter
Patch Set: size_t -> uint32_t Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gin/dictionary.h ('K') | « gin/test/file.cc ('k') | gin/try_catch.cc » ('j') | gin/try_catch.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/try_catch.h
diff --git a/gin/try_catch.h b/gin/try_catch.h
index 633b909234139c3040333732b9166b70f4e21b97..0e0c68be1418d2febc60ded6ebb6efe0850270d5 100644
--- a/gin/try_catch.h
+++ b/gin/try_catch.h
@@ -16,7 +16,7 @@ namespace gin {
// TryCatch is a convenient wrapper around v8::TryCatch.
class GIN_EXPORT TryCatch {
public:
- TryCatch();
+ explicit TryCatch(v8::Isolate* isolate);
~TryCatch();
bool HasCaught();
« gin/dictionary.h ('K') | « gin/test/file.cc ('k') | gin/try_catch.cc » ('j') | gin/try_catch.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698