Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/shell/gin_main.cc

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter
Patch Set: size_t -> uint32_t Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gin/dictionary.h ('K') | « gin/object_template_builder.cc ('k') | gin/shell_runner.cc » ('j') | gin/try_catch.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell/gin_main.cc
diff --git a/gin/shell/gin_main.cc b/gin/shell/gin_main.cc
index d3bab721bebd82aa0d0741863a1d859c6919bab1..62143c9926f5a609ff95c2c3ef593a351df4925f 100644
--- a/gin/shell/gin_main.cc
+++ b/gin/shell/gin_main.cc
@@ -75,7 +75,9 @@ int main(int argc, char** argv) {
{
gin::Runner::Scope scope(&runner);
- v8::V8::SetCaptureStackTraceForUncaughtExceptions(true);
+ runner.GetContextHolder()
+ ->isolate()
+ ->SetCaptureStackTraceForUncaughtExceptions(true);
}
base::CommandLine::StringVector args =
« gin/dictionary.h ('K') | « gin/object_template_builder.cc ('k') | gin/shell_runner.cc » ('j') | gin/try_catch.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698