Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gin/modules/module_registry.h

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index 439207eaf3f51e6f6a590125567cc61c91904e46..7050a5a38361f4851865db79d7352aa00d33ad29 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -47,7 +47,7 @@ class GIN_EXPORT ModuleRegistry {
// Installs the necessary functions needed for modules.
// WARNING: this may execute script in the page.
- static void InstallGlobals(v8::Isolate* isolate, v8::Handle<v8::Object> obj);
+ static bool InstallGlobals(v8::Isolate* isolate, v8::Handle<v8::Object> obj);
void AddObserver(ModuleRegistryObserver* observer);
void RemoveObserver(ModuleRegistryObserver* observer);
@@ -81,8 +81,8 @@ class GIN_EXPORT ModuleRegistry {
explicit ModuleRegistry(v8::Isolate* isolate);
- void Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
- void RegisterModule(v8::Isolate* isolate,
+ bool Load(v8::Isolate* isolate, scoped_ptr<PendingModule> pending);
+ bool RegisterModule(v8::Isolate* isolate,
const std::string& id,
v8::Handle<v8::Value> module);

Powered by Google App Engine
This is Rietveld 408576698