Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1106383008: Remove unused Module-related AST nodes and associated codegen (Closed)

Created:
5 years, 7 months ago by adamk
Modified:
5 years, 7 months ago
CC:
v8-dev, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused Module-related AST nodes and associated codegen BUG=v8:1569 LOG=n Committed: https://crrev.com/d18dd375ac82f04a4c64e6b75bc04808533b7cd9 Cr-Commit-Position: refs/heads/master@{#28179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -791 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ast.h View 7 chunks +0 lines, -109 lines 0 comments Download
M src/ast-numbering.cc View 4 chunks +0 lines, -35 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen.cc View 5 chunks +0 lines, -215 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/prettyprinter.cc View 6 chunks +0 lines, -85 lines 0 comments Download
M src/rewriter.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/typing.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 7 months ago (2015-04-29 19:10:31 UTC) #2
arv (Not doing code reviews)
lgtm
5 years, 7 months ago (2015-04-30 16:12:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106383008/1
5 years, 7 months ago (2015-04-30 16:13:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 16:20:56 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 16:21:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d18dd375ac82f04a4c64e6b75bc04808533b7cd9
Cr-Commit-Position: refs/heads/master@{#28179}

Powered by Google App Engine
This is Rietveld 408576698