Dart: Adds mojom pub package.

Dart: Adds mojom pub package.

Creates generate.dart script that installs generated .mojom.dart files into
the mojom pub package.

Updates Sky's deploy_sdk.py script to put mojom.dart files in locations where
they can be consumed by the generate.dart script once the SDK is published and
obtained via "pub get".

This CL is adapted from a patch by zra@google.com; most of the work here is his.

R=iposva@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/488fdf045e586abb0f722358b0560d1bd30845ba

[blundell, 2015-04-28 09:53:11]

blundell@chromium.org changed reviewers:
+ eseidel@chromium.org, iposva@google.com

[blundell, 2015-04-28 09:53:12]

Hi Eric and Ivan,

This patch takes over from zra's. The delta is:

- Migrated init.dart to generate.dart and changed it to work correctly if "-p"
isn't passed.
- Updated deploy_sdk.py to avoid having a mojom package in the deployed Sky SDK
and create the mojom package correctly if "--fake-pub-get-into" is specified.

[blundell, 2015-04-28 14:26:03]

On 2015/04/28 09:53:12, blundell wrote:
> Hi Eric and Ivan,
> 
> This patch takes over from zra's. The delta is:
> 
> - Migrated init.dart to generate.dart and changed it to work correctly if "-p"
> isn't passed.
> - Updated deploy_sdk.py to avoid having a mojom package in the deployed Sky
SDK
> and create the mojom package correctly if "--fake-pub-get-into" is specified.

BTW, I know that the Dart Summit is today & tomorrow, so I'm not expecting
reviews until later this week :).

[blundell, 2015-05-04 08:54:50]

ping :)

[eseidel, 2015-05-04 18:07:18]

The packages I've published have been as "Chromium Authors" and not had the
PATENTS file, etc.  I'm not sure about all the various file bits, but the code
and idea look fine.

[Ivan Posva, 2015-05-04 21:49:12]

Not sure which of the files Eric mentioned you want to publish.

The Dart code looked fine to me. You will need to update the pubspec.yaml to
allow the script to be executed with pub run though.

-Ivan

https://codereview.chromium.org/1106383006/diff/40001/mojo/dart/mojom/README.md
File mojo/dart/mojom/README.md (right):

https://codereview.chromium.org/1106383006/diff/40001/mojo/dart/mojom/README....
mojo/dart/mojom/README.md:10: $ pub run mojom:init -p `pwd`/packages
You probably want to also rename the file to be init.dart instead of
generate.dart. You certainly want to update the pubspec.yaml to include a
"executables:" section according to the documentation at
https://www.dartlang.org/tools/pub/pubspec.html#executables

[blundell, 2015-05-05 15:13:13]

Thanks for the reviews.

Ivan, I'll defer to your opinion on the content of the metadata that is included
in the mojom package, which we'll publish once this CL lands. I simply adopted
what had been in zra's CL (https://codereview.chromium.org/1052993014/).

https://codereview.chromium.org/1106383006/diff/40001/mojo/dart/mojom/README.md
File mojo/dart/mojom/README.md (right):

https://codereview.chromium.org/1106383006/diff/40001/mojo/dart/mojom/README....
mojo/dart/mojom/README.md:10: $ pub run mojom:init -p `pwd`/packages
On 2015/05/04 21:49:12, Ivan Posva wrote:
> You probably want to also rename the file to be init.dart instead of
> generate.dart. You certainly want to update the pubspec.yaml to include a
> "executables:" section according to the documentation at
> https://www.dartlang.org/tools/pub/pubspec.html#executables

Per offline discussion:

- Updated this comment to say "mojom:generate" instead.
- It seems like we don't need the "executables:" section here since we're not
looking to expose generate.dart as a stand-alone shell command.

[blundell, 2015-05-06 14:11:17]

Patchset #5 (id:80001) has been deleted

[blundell, 2015-05-06 14:13:38]

Patchset #4 (id:60001) has been deleted

[blundell, 2015-05-06 14:14:04]

Patchset #4 (id:100001) has been deleted

[blundell, 2015-05-06 14:15:59]

I updated this package to be authored by Chromium.

Ivan, I also added the ability to specify additional mojom dirs to
generate.dart; some consumers will need that as they generate mojom.dart files
locally via GN. Please take a look at the changes there.

[Ivan Posva, 2015-05-07 04:09:57]

LGTM for the Dart code. We probably want to address the comments in the
pubspec.yaml though.

-Ivan

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/README.md
File mojo/dart/mojom/README.md (right):

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/README...
mojo/dart/mojom/README.md:16: $ pub run mojom:generate -a <path/to/mojom/dir>
How about </path/to/mojom/dir> to signal that you expect an absolute path?

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
File mojo/dart/mojom/pubspec.yaml (right):

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
mojo/dart/mojom/pubspec.yaml:3: author: Dart Team <misc@dartlang.org>
Didn't you want to switch this to "Chromium Authors"?

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
mojo/dart/mojom/pubspec.yaml:5: homepage: https://www.dartlang.org
You probably want to change this accordingly. For example to
https://github.com/domokit/mojo

[blundell, 2015-05-07 13:07:11]

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/README.md
File mojo/dart/mojom/README.md (right):

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/README...
mojo/dart/mojom/README.md:16: $ pub run mojom:generate -a <path/to/mojom/dir>
On 2015/05/07 04:09:57, Ivan Posva wrote:
> How about </path/to/mojom/dir> to signal that you expect an absolute path?

Done.

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
File mojo/dart/mojom/pubspec.yaml (right):

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
mojo/dart/mojom/pubspec.yaml:3: author: Dart Team <misc@dartlang.org>
On 2015/05/07 04:09:57, Ivan Posva wrote:
> Didn't you want to switch this to "Chromium Authors"?

whoops, missed this file. Done.

https://codereview.chromium.org/1106383006/diff/120001/mojo/dart/mojom/pubspe...
mojo/dart/mojom/pubspec.yaml:5: homepage: https://www.dartlang.org
On 2015/05/07 04:09:57, Ivan Posva wrote:
> You probably want to change this accordingly. For example to
> https://github.com/domokit/mojo

Done.

[Ivan Posva, 2015-05-07 13:15:13]

Still LGTM.

-Ivan

[blundell, 2015-05-07 13:23:10]

Committed patchset #6 (id:160001) manually as
488fdf045e586abb0f722358b0560d1bd30845ba (presubmit successful).

[jamesr, 2015-05-07 17:56:04]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-05-07 17:56:04]

'git status' for me is showing:

# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	mojo/dart/mojom/bin/packages

should this path be in //.gitignore or have I done something wrong?

[blundell, 2015-05-07 18:47:37]

On 2015/05/07 17:56:04, jamesr wrote:
> 'git status' for me is showing:
> 
> # Untracked files:
> #   (use "git add <file>..." to include in what will be committed)
> #
> #	mojo/dart/mojom/bin/packages
> 
> should this path be in //.gitignore or have I done something wrong?

Oops. "packages/" is in .gitignore but this one is a symlink so it doesn't match
that. I don't have access to a terminal and am about to head offline for the
long weekend; if you want to change the "packages/" in .gitignore to "packages"
that would be great. Otherwise I'll do it on Monday.

[jamesr, 2015-05-07 19:22:47]

On 2015/05/07 18:47:37, blundell wrote:
> On 2015/05/07 17:56:04, jamesr wrote:
> > 'git status' for me is showing:
> > 
> > # Untracked files:
> > #   (use "git add <file>..." to include in what will be committed)
> > #
> > #	mojo/dart/mojom/bin/packages
> > 
> > should this path be in //.gitignore or have I done something wrong?
> 
> Oops. "packages/" is in .gitignore but this one is a symlink so it doesn't
match
> that. I don't have access to a terminal and am about to head offline for the
> long weekend; if you want to change the "packages/" in .gitignore to
"packages"
> that would be great. Otherwise I'll do it on Monday.

I can do that.  Have a good weekend!