Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1106373002: Add a script to sky pub package to download assets (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a script to sky pub package to download assets This is a fork of sky/tools/download_material_design_assets which does not depend on depot_tools and assumes that its right next to the assets directory instead of finding it relative to the mojo root. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3e0fefeb87338ecbd5a3ea6191134a3ac345a31c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
A + sky/sdk/packages/sky/lib/download_material_design_icons View 1 chunk +9 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 8 months ago (2015-04-27 23:22:34 UTC) #1
Hixie
lgtm
5 years, 8 months ago (2015-04-27 23:25:36 UTC) #2
Hixie
On 2015/04/27 at 23:25:36, Hixie wrote: > lgtm (with the caveat that I don't know ...
5 years, 8 months ago (2015-04-27 23:25:54 UTC) #3
eseidel
5 years, 8 months ago (2015-04-27 23:27:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e0fefeb87338ecbd5a3ea6191134a3ac345a31c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698