Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1106363003: [Chromecast] Always receive notifications. (Closed)

Created:
5 years, 8 months ago by derekjchow1
Modified:
5 years, 8 months ago
Reviewers:
gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Always receive notifications. Call registerToReceiveNotificationsAlways in CastBrowserHelper. Cast shell expects to receive network notifications at all times to properly update network state. R=gunsch@chromium.org BUG=internal b/20641901 Committed: https://crrev.com/8fbbc669b356f7c25b8c6417738986f5c8525d37 Cr-Commit-Position: refs/heads/master@{#327196}

Patch Set 1 #

Patch Set 2 : Always listen #

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
derekjchow1
PTAL. Do you think it's worth adding a comment before NetworkChangeNotifier.init?
5 years, 8 months ago (2015-04-28 00:09:47 UTC) #1
gunsch
BUG=b/20641901 And sure, go ahead and add a comment explaining the purpose. Otherwise lgtm.
5 years, 8 months ago (2015-04-28 00:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106363003/40001
5 years, 8 months ago (2015-04-28 00:24:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-28 00:42:56 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 00:44:26 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8fbbc669b356f7c25b8c6417738986f5c8525d37
Cr-Commit-Position: refs/heads/master@{#327196}

Powered by Google App Engine
This is Rietveld 408576698