Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1106353002: win: Don't show style plugin warnings for generated files. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
hans, dcheng
CC:
dcheng, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Don't show style plugin warnings for generated files. BUG=477846 NOTRY=true Committed: https://crrev.com/112702a00f518bff00c52a075e71bd7157fbc085 Cr-Commit-Position: refs/heads/master@{#327158}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 2 chunks +10 lines, -3 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
Nico
5 years, 8 months ago (2015-04-27 22:12:14 UTC) #2
hans
lgtm
5 years, 8 months ago (2015-04-27 22:16:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106353002/1
5 years, 8 months ago (2015-04-27 22:23:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 22:27:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/112702a00f518bff00c52a075e71bd7157fbc085 Cr-Commit-Position: refs/heads/master@{#327158}
5 years, 8 months ago (2015-04-27 22:28:52 UTC) #7
dcheng
https://codereview.chromium.org/1106353002/diff/1/tools/clang/plugins/ChromeClassTester.cpp File tools/clang/plugins/ChromeClassTester.cpp (right): https://codereview.chromium.org/1106353002/diff/1/tools/clang/plugins/ChromeClassTester.cpp#newcode150 tools/clang/plugins/ChromeClassTester.cpp:150: filename.insert(filename.begin(), '/'); Would it make sense to use llvm::sys::fs::make_absolute? ...
5 years, 8 months ago (2015-04-27 22:31:21 UTC) #9
Nico
5 years, 8 months ago (2015-04-27 22:57:00 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1106353002/diff/1/tools/clang/plugins/ChromeC...
File tools/clang/plugins/ChromeClassTester.cpp (right):

https://codereview.chromium.org/1106353002/diff/1/tools/clang/plugins/ChromeC...
tools/clang/plugins/ChromeClassTester.cpp:150: filename.insert(filename.begin(),
'/');
On 2015/04/27 22:31:21, dcheng wrote:
> Would it make sense to use llvm::sys::fs::make_absolute? This seems slightly
> hacky =)

That'd work too I suppose. Nothing wrong with "/c:/foo/bar" though, is there?
;-)

Powered by Google App Engine
This is Rietveld 408576698