Issue 1106333003: Revert "Make CFX_WideString::LockBuffer() completely unused."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1106333003: Revert "Make CFX_WideString::LockBuffer() completely unused." (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Make CFX_WideString::LockBuffer() completely unused." This reverts commit ee7412f5aef353e5c6f1a64d0e1708ed926869d9. Reason for revert: VS compile broke. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/00948f58ae4ba3713e2e25080c9e229ecbe929eb

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -4 lines)			Patch
M	core/include/fxcrt/fx_string.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	core/src/fpdfdoc/doc_bookmark.cpp	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_bstring.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Committed patchset #1 (id:1) manually as 00948f58ae4ba3713e2e25080c9e229ecbe929eb (tree was closed).

5 years, 7 months ago (2015-04-27 22:10:04 UTC) #2

Tom Sepez

5 years, 7 months ago (2015-04-27 22:12:05 UTC) #3

On 2015/04/27 22:10:04, Tom Sepez wrote:
> Committed patchset #1 (id:1) manually as
> 00948f58ae4ba3713e2e25080c9e229ecbe929eb (tree was closed).

Re-opened due to revert.

Expand Messages | Collapse Messages