Source/core/dom/StyleEngine.cpp - Issue 1106313003: Null check collection handling dirty scopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/StyleEngine.cpp

Issue 1106313003: Null check collection handling dirty scopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Alternative fix checking for collection in markTreeScopeDirty Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/StyleEngine.cpp

diff --git a/Source/core/dom/StyleEngine.cpp b/Source/core/dom/StyleEngine.cpp

index d25247045e79e69558b151b2e439ffa065cc32dc..a1181c8f8a103dca05334648729ca10915fbc968 100644

--- a/Source/core/dom/StyleEngine.cpp

+++ b/Source/core/dom/StyleEngine.cpp

@@ -579,7 +579,8 @@ void StyleEngine::markTreeScopeDirty(TreeScope& scope)

return;

}

- m_dirtyTreeScopes.add(&scope);

+ if (m_styleSheetCollectionMap.contains(&scope))

tasak 2015/04/30 08:16:20 I think, it would be better to use ASSERT here, i.

rune 2015/04/30 08:35:45 Done.

+ m_dirtyTreeScopes.add(&scope);

}

void StyleEngine::markDocumentDirty()

« no previous file with comments | « LayoutTests/fast/dom/shadow/remove-stylesheet-from-shadow-crash-expected.txt ('k') | no next file » | no next file with comments »