Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1106313002: Revert of Limit form-less Autofilling to pages that look like checkout pages. (Closed)

Created:
5 years, 7 months ago by mohsen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Limit form-less Autofilling to pages that look like checkout pages. (patchset #7 id:120001 of https://codereview.chromium.org/1081803003/) Reason for revert: Caused compile error on Win x64 GN bot Original issue's description: > Limit form-less Autofilling to pages that look like checkout pages. > > This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout. > > Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information"). > > BUG=471090, 477466 > > Committed: https://crrev.com/aa3219ce27ef5471c19670fe5145b136925cbc89 > Cr-Commit-Position: refs/heads/master@{#327108} TBR=thestig@chromium.org,brettw@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471090, 477466 Committed: https://crrev.com/f44602c3bbc05303167de26b707af9cd29f931e1 Cr-Commit-Position: refs/heads/master@{#327116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -1083 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 28 chunks +21 lines, -41 lines 0 comments Download
M chrome/test/data/autofill/autofill_noform_dynamic.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/25_checkout_m_llbean.com.html View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/b465571.html View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_454366.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_454366b.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_459132.html View 4 chunks +6 lines, -756 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_460832.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_462080.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_463856.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_465053.html View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_465576.html View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_471748.html View 1 chunk +34 lines, -39 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_471831.html View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/b465571.out View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_459132.out View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_465576.out View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_471748.out View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill.gypi View 3 chunks +2 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 4 chunks +6 lines, -23 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A components/autofill/core/browser/autofill_regexes.h View 1 chunk +20 lines, -0 lines 0 comments Download
A components/autofill/core/browser/autofill_regexes.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A components/autofill/core/browser/autofill_regexes_unittest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/common/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D components/autofill/core/common/autofill_regexes.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/autofill/core/common/autofill_regexes.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D components/autofill/core/common/autofill_regexes_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mohsen
Created Revert of Limit form-less Autofilling to pages that look like checkout pages.
5 years, 7 months ago (2015-04-27 21:02:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106313002/1
5 years, 7 months ago (2015-04-27 21:05:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 21:08:25 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:09:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f44602c3bbc05303167de26b707af9cd29f931e1
Cr-Commit-Position: refs/heads/master@{#327116}

Powered by Google App Engine
This is Rietveld 408576698