build/gyp_chromium - Issue 1106283004: Disable circular gyp dependency check on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 1106283004: Disable circular gyp dependency check on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index 4ed15bac29c625703530aced70f5ebb1dd64dc32..a21ea69fb4e36afeabd313ab1140c99a2257b091 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -263,8 +263,8 @@ if __name__ == '__main__':

# option. http://crbug.com/35878.

# TODO(tc): Fix circular dependencies in ChromiumOS then add linux2 to the

# list.

- if sys.platform not in ('darwin',):

- args.append('--no-circular-check')

+ #if sys.platform not in ('darwin',):

Fady Samuel 2015/04/28 22:33:04 Should I remove this and add to the TODOs above?

+ args.append('--no-circular-check')

# We explicitly don't support the make gyp generator (crbug.com/348686). Be

# nice and fail here, rather than choking in gyp.

« no previous file with comments | « no previous file | no next file » | no next file with comments »