Disable circular gyp dependency check on Mac

Disable circular gyp dependency check on Mac

It's very easy to get into a situation where components.gyp depends on content_shell_and_tests.gyp which depends on components.gyp. This CL gets rid of the check on Mac. The dependency check is now only performed on iOS.

BUG=none

Committed: https://crrev.com/9449f96ffd22a93d929b6fa034903c76f89fb754
Cr-Commit-Position: refs/heads/master@{#327826}

[Fady Samuel, 2015-04-28 22:33:03]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org

[Fady Samuel, 2015-04-28 22:33:04]

https://codereview.chromium.org/1106283004/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/1106283004/diff/1/build/gyp_chromium#newcode266
build/gyp_chromium:266: #if sys.platform not in ('darwin',):
Should I remove this and add to the TODOs above?

[Fady Samuel, 2015-04-28 23:38:47]

PTAL

[jam, 2015-04-30 19:33:06]

lgtm

update description as well

https://codereview.chromium.org/1106283004/diff/20001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/1106283004/diff/20001/build/gyp_chromium#newc...
build/gyp_chromium:262: # bypassed on other platforms, but is left enabled on
the Mac, where a
nit: update

[Fady Samuel, 2015-04-30 21:50:09]

Addressed nit. CQ'ing now.

https://codereview.chromium.org/1106283004/diff/20001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/1106283004/diff/20001/build/gyp_chromium#newc...
build/gyp_chromium:262: # bypassed on other platforms, but is left enabled on
the Mac, where a
On 2015/04/30 19:33:06, jam wrote:
> nit: update

Done.

[Fady Samuel, 2015-04-30 21:50:19]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-04-30 21:50:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1106283004/#ps40001
(title: "Addressed comment")

[commit-bot: I haz the power, 2015-04-30 21:52:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106283004/40001

[commit-bot: I haz the power, 2015-04-30 23:12:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-30 23:13:58]

Patchset 3 (id:??) landed as
https://crrev.com/9449f96ffd22a93d929b6fa034903c76f89fb754
Cr-Commit-Position: refs/heads/master@{#327826}