Support Android secure codecs in requestMediaKeySystemAccess().

components/cdm/renderer/android_key_systems.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cdm/renderer/android_key_systems.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 21 matching lines @@
   request.codecs = media::EME_CODEC_ALL;
   content::RenderThread::Get()->Send(
       new ChromeViewHostMsg_QueryKeySystemSupport(request, &response));
   DCHECK(!(response.compositing_codecs & ~media::EME_CODEC_ALL))
       << "unrecognized codec";
   DCHECK(!(response.non_compositing_codecs & ~media::EME_CODEC_ALL))
       << "unrecognized codec";
   return response;
 }
 
-void AddAndroidWidevine(std::vector<KeySystemInfo>* concrete_key_systems,
-                        bool is_non_compositing_supported) {
+void AddAndroidWidevine(std::vector<KeySystemInfo>* concrete_key_systems) {
   SupportedKeySystemResponse response = QueryKeySystemSupport(
       kWidevineKeySystem);
 
-  // When creating the WIDEVINE key system, BrowserCdmFactoryAndroid configures
-  // the CDM's security level based on a pref. Therefore the supported
-  // codec/robustenss combinations depend on that pref, represented by
-  // |bool is_non_compositing_supported|.
-  // TODO(sandersd): For unprefixed, set the security level based on the
-  // requested robustness instead of the flag. http://crbug.com/467779
-  // We should also stop using the term "non_compositing."
-  SupportedCodecs codecs = response.compositing_codecs;
-  EmeRobustness max_audio_robustness = EmeRobustness::SW_SECURE_CRYPTO;
-  EmeRobustness max_video_robustness = EmeRobustness::SW_SECURE_CRYPTO;
-  if (is_non_compositing_supported) {
-    codecs = response.non_compositing_codecs;
-    max_audio_robustness = EmeRobustness::HW_SECURE_CRYPTO;
-    max_video_robustness = EmeRobustness::HW_SECURE_ALL;
-  }
-
   // We are using MediaDrm API on Android and we cannot guarantee that API
   // doesn't use persistent storage on the device. Therefore always set
   // persistent state to EmeFeatureSupport::ALWAYS_ENABLED to err on the
   // safe side.
-
-  if (codecs != media::EME_CODEC_NONE) {
+  if (response.compositing_codecs != media::EME_CODEC_NONE) {

[ddorwin, 2015/04/30 18:18:04]

Should we DCHECK that this is not NONE if noncomp is not NONE? This would be
unexpected and cause unprefixed to never work, right?

[sandersd (OOO until July 31), 2015/04/30 19:57:44]

Done.

     AddWidevineWithCodecs(
-        WIDEVINE, codecs, max_audio_robustness, max_video_robustness,
-        media::EmeSessionTypeSupport::NOT_SUPPORTED,  // persistent-license.
-        media::EmeSessionTypeSupport::
-            NOT_SUPPORTED,  // persistent-release-message.
-        media::EmeFeatureSupport::ALWAYS_ENABLED,  // Persistent state.
-        media::EmeFeatureSupport::ALWAYS_ENABLED,  // Distinctive
-                                                   // identifier.
+        WIDEVINE,
+        response.compositing_codecs,            // Regular codecs.
+        response.non_compositing_codecs,        // Hardware-secure codecs.
+        EmeRobustness::HW_SECURE_CRYPTO,        // Max audio robustness.
+        EmeRobustness::HW_SECURE_ALL,           // Max video robustness.
+        media::EME_SESSION_TYPE_NOT_SUPPORTED,  // persistent-license.

[jrummell, 2015/04/30 02:08:37]

Shouldn't these be media::EmeSessionTypeSupport::?

[sandersd (OOO until July 31), 2015/04/30 18:19:34]

Done.

+        media::EME_SESSION_TYPE_NOT_SUPPORTED,  // persistent-release-message.
+        media::EME_FEATURE_ALWAYS_ENABLED,      // Persistent state.
+        media::EME_FEATURE_ALWAYS_ENABLED,      // Distinctive identifier.
         concrete_key_systems);
   }
 
   // For compatibility with the prefixed API, register a separate L1 key system.
-  // When creating the WIDEVINE_HR_NON_COMPOSITING key system,
-  // BrowserCdmFactoryAndroid does not configure the CDM's security level (that
-  // is, leaves it as L1); therefore only secure codecs are supported.
-  // TODO(ddorwin): Remove with unprefixed. http://crbug.com/249976
+  // This key systems acts as though only hardware-secure codecs are available.
+  // (The prefixed API only consults the regular codecs field.)
+  // TODO(sandersd): Only register if the hardware-secure codecs pref is set.
   if (response.non_compositing_codecs != media::EME_CODEC_NONE) {
+    SupportedCodecs codecs = response.compositing_codecs &

[ddorwin, 2015/04/30 18:18:04]

Probably worth a comment explaining why.

[sandersd (OOO until July 31), 2015/04/30 19:57:44]

Done.

+                             response.non_compositing_codecs;
     AddWidevineWithCodecs(
-        WIDEVINE_HR_NON_COMPOSITING, response.non_compositing_codecs,
-        EmeRobustness::HW_SECURE_CRYPTO,              // Max audio robustness.
-        EmeRobustness::HW_SECURE_ALL,                 // Max video robustness.
-        media::EmeSessionTypeSupport::NOT_SUPPORTED,  // persistent-license.
-        media::EmeSessionTypeSupport::
-            NOT_SUPPORTED,  // persistent-release-message.
-        media::EmeFeatureSupport::ALWAYS_ENABLED,  // Persistent state.
-        media::EmeFeatureSupport::ALWAYS_ENABLED,  // Distinctive
-                                                   // identifier.
+        WIDEVINE_HR_NON_COMPOSITING,
+        (response.compositing_codecs &
+         response.non_compositing_codecs),      // Regular codecs.

[jrummell, 2015/04/30 02:08:37]

Can't you just use codecs here? Surprised the compiler doesn't complain about
unused variable.

[sandersd (OOO until July 31), 2015/04/30 18:19:34]

Done.

+        media::EME_CODEC_NONE,                  // Hardware-secure codecs.
+        EmeRobustness::HW_SECURE_CRYPTO,        // Max audio robustness.
+        EmeRobustness::HW_SECURE_ALL,           // Max video robustness.
+        media::EME_SESSION_TYPE_NOT_SUPPORTED,  // persistent-license.
+        media::EME_SESSION_TYPE_NOT_SUPPORTED,  // persistent-release-message.
+        media::EME_FEATURE_ALWAYS_ENABLED,      // Persistent state.
+        media::EME_FEATURE_ALWAYS_ENABLED,      // Distinctive identifier.
         concrete_key_systems);
   }
 }
 
 void AddAndroidPlatformKeySystems(
     std::vector<KeySystemInfo>* concrete_key_systems) {
   std::vector<std::string> key_system_names;
   content::RenderThread::Get()->Send(
       new ChromeViewHostMsg_GetPlatformKeySystemNames(&key_system_names));
 
   for (std::vector<std::string>::const_iterator it = key_system_names.begin();
        it != key_system_names.end(); ++it) {
     SupportedKeySystemResponse response = QueryKeySystemSupport(*it);
     if (response.compositing_codecs != media::EME_CODEC_NONE) {
       KeySystemInfo info;
       info.key_system = *it;
       info.supported_codecs = response.compositing_codecs;
       // Here we assume that support for a container implies support for the
       // associated initialization data type. KeySystems handles validating
       // |init_data_type| x |container| pairings.
       if (response.compositing_codecs & media::EME_CODEC_WEBM_ALL)
         info.supported_init_data_types |= media::kInitDataTypeMaskWebM;
 #if defined(USE_PROPRIETARY_CODECS)
       if (response.compositing_codecs & media::EME_CODEC_MP4_ALL)
         info.supported_init_data_types |= media::kInitDataTypeMaskCenc;
 #endif  // defined(USE_PROPRIETARY_CODECS)
       info.max_audio_robustness = EmeRobustness::EMPTY;
       info.max_video_robustness = EmeRobustness::EMPTY;
-      // Assume the worst case (from a user point of view).
+      // Assume that plaform key systems support no features but can and will

[jrummell, 2015/04/30 02:08:37]

s/plaform/platform/

[sandersd (OOO until July 31), 2015/04/30 18:19:34]

Done.

+      // make use of persistence and identifiers.
       info.persistent_license_support =
           media::EmeSessionTypeSupport::NOT_SUPPORTED;
       info.persistent_release_message_support =
           media::EmeSessionTypeSupport::NOT_SUPPORTED;
       info.persistent_state_support = media::EmeFeatureSupport::ALWAYS_ENABLED;
       info.distinctive_identifier_support =
           media::EmeFeatureSupport::ALWAYS_ENABLED;
       concrete_key_systems->push_back(info);
     }
   }
 }
 
 }  // namespace cdm