Issue 1106263002: Address review comments on https://codereview.chromium.org/1077893005/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1106263002: Address review comments on https://codereview.chromium.org/1077893005/ (Closed)

Created:
5 years, 8 months ago by Nico

Modified:
5 years, 8 months ago

Reviewers:
Will Harris

CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org, majnemer

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Address review comments on https://codereview.chromium.org/1077893005/ Add a comment to UpdateProcThreadAttribute() to note that its parameter needs to outlive this. BUG=476316 Committed: https://crrev.com/eda7a91b3df70493893a036b34c42ff8ca150340 Cr-Commit-Position: refs/heads/master@{#327176}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	base/win/startup_information.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106263002/1

5 years, 8 months ago (2015-04-27 22:51:58 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 23:44:23 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eda7a91b3df70493893a036b34c42ff8ca150340
Cr-Commit-Position: refs/heads/master@{#327176}