Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1106213003: Optimize writes upon ProfileManager::UpdateLastUser. (Closed)

Created:
5 years, 7 months ago by Mike Lerman
Modified:
5 years, 7 months ago
Reviewers:
bcwhite
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize writes upon ProfileManager::UpdateLastUser. BUG=481721 Committed: https://crrev.com/91ead71d324572a1f50cc8c7d93ffe058a67b874 Cr-Commit-Position: refs/heads/master@{#327498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike Lerman
Hi Brian, I'm trying to optimize the LastActiveTime to reduce disk writes and application wake ...
5 years, 7 months ago (2015-04-28 18:23:58 UTC) #2
bcwhite
LGTM You can increase the minimum interval to as much as one full day if ...
5 years, 7 months ago (2015-04-29 14:27:45 UTC) #3
Mike Lerman
I think this will be sufficient for the needs - but good to know. Thanks!
5 years, 7 months ago (2015-04-29 14:33:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106213003/1
5 years, 7 months ago (2015-04-29 15:11:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 16:00:19 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:01:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ead71d324572a1f50cc8c7d93ffe058a67b874
Cr-Commit-Position: refs/heads/master@{#327498}

Powered by Google App Engine
This is Rietveld 408576698