Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: sandbox/win/src/win2k_threadpool.cc

Issue 1106203002: sandbox/win: Fix warnings found by clang chromium-style plugin on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sandbox/win/src/win2k_threadpool.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/win/src/win2k_threadpool.h" 5 #include "sandbox/win/src/win2k_threadpool.h"
6 6
7 #include "sandbox/win/src/win_utils.h" 7 #include "sandbox/win/src/win_utils.h"
8 8
9 namespace sandbox { 9 namespace sandbox {
10 10
11 Win2kThreadPool::Win2kThreadPool() {
12 ::InitializeCriticalSection(&lock_);
13 }
14
11 bool Win2kThreadPool::RegisterWait(const void* cookie, HANDLE waitable_object, 15 bool Win2kThreadPool::RegisterWait(const void* cookie, HANDLE waitable_object,
12 CrossCallIPCCallback callback, 16 CrossCallIPCCallback callback,
13 void* context) { 17 void* context) {
14 if (0 == cookie) { 18 if (0 == cookie) {
15 return false; 19 return false;
16 } 20 }
17 HANDLE pool_object = NULL; 21 HANDLE pool_object = NULL;
18 // create a wait for a kernel object, with no timeout 22 // create a wait for a kernel object, with no timeout
19 if (!::RegisterWaitForSingleObject(&pool_object, waitable_object, callback, 23 if (!::RegisterWaitForSingleObject(&pool_object, waitable_object, callback,
20 context, INFINITE, WT_EXECUTEDEFAULT)) { 24 context, INFINITE, WT_EXECUTEDEFAULT)) {
(...skipping 30 matching lines...) Expand all
51 } 55 }
52 56
53 Win2kThreadPool::~Win2kThreadPool() { 57 Win2kThreadPool::~Win2kThreadPool() {
54 // Here we used to unregister all the pool wait handles. Now, following the 58 // Here we used to unregister all the pool wait handles. Now, following the
55 // rest of the code we avoid lengthy or blocking calls given that the process 59 // rest of the code we avoid lengthy or blocking calls given that the process
56 // is being torn down. 60 // is being torn down.
57 ::DeleteCriticalSection(&lock_); 61 ::DeleteCriticalSection(&lock_);
58 } 62 }
59 63
60 } // namespace sandbox 64 } // namespace sandbox
OLDNEW
« no previous file with comments | « sandbox/win/src/win2k_threadpool.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698