Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1106203002: sandbox/win: Fix warnings found by clang chromium-style plugin on Windows. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sanbox/win: Fix warnings found by clang chromium-style plugin on Windows. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/605/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inline body. warning(clang): [chromium-style] Complex destructor has an inline body. warning(clang): [chromium-style] complex class/struct needs an explicit out-of-line constructor. warning(clang): [chromium-style] complex class/struct needs an explicit out-of-line destructor. BUG=467287 R=thakis@chromium.org,cpu@chromium.org Committed: https://crrev.com/25f1faa117156fcf67dc910d551e8225c50bfe75 Cr-Commit-Position: refs/heads/master@{#327069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -19 lines) Patch
M sandbox/win/src/crosscall_server.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/crosscall_server.cc View 2 chunks +8 lines, -1 line 0 comments Download
M sandbox/win/src/handle_closer.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/handle_closer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/win/src/handle_table.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sandbox/win/src/handle_table.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M sandbox/win/src/policy_low_level.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/policy_low_level.cc View 2 chunks +6 lines, -1 line 0 comments Download
M sandbox/win/src/restricted_token.h View 1 chunk +2 lines, -8 lines 0 comments Download
M sandbox/win/src/restricted_token.cc View 1 chunk +11 lines, -1 line 0 comments Download
M sandbox/win/src/win2k_threadpool.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sandbox/win/src/win2k_threadpool.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
Nico, is Carlos available to review this? Is it fine to TBR him, if not?
5 years, 8 months ago (2015-04-27 14:48:05 UTC) #1
Nico
cpu seemed to not be around last week at least. I'd say wait a few ...
5 years, 8 months ago (2015-04-27 17:29:59 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-04-27 17:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106203002/1
5 years, 8 months ago (2015-04-27 18:00:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 18:06:33 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:07:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25f1faa117156fcf67dc910d551e8225c50bfe75
Cr-Commit-Position: refs/heads/master@{#327069}

Powered by Google App Engine
This is Rietveld 408576698