Issue 11062004: Fix crash in a few of the tests in content_browsertests on Linux. The problem was that DesktopActiv…

Issue 11062004: Fix crash in a few of the tests in content_browsertests on Linux. The problem was that DesktopActiv… (Closed)

Created:
8 years, 2 months ago by jam

Modified:
8 years, 2 months ago

Reviewers:
Ben Goodger (Google), jar (doing other things)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash in a few of the tests in content_browsertests on Linux. The problem was that DesktopActivationClient would be created after an aura::Window so it would never register for notifications that it went away. As a result it would call a deleted Window in its ActivateWindow method. BUG=146077 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160386

Patch Set 1 : #

Patch Set 2 : actually need to use test compositor on bots #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	base/scoped_observer.h	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	ui/aura/desktop/desktop_activation_client.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	ui/aura/desktop/desktop_activation_client.cc	View	4 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

If you don't mind fixing it... there is a nearby typo..... but in any case, ...

8 years, 2 months ago (2012-10-05 16:00:31 UTC) #5

jam

8 years, 2 months ago (2012-10-05 16:02:46 UTC) #6

https://codereview.chromium.org/11062004/diff/9002/base/scoped_observer.h
File base/scoped_observer.h (right):

https://codereview.chromium.org/11062004/diff/9002/base/scoped_observer.h#new...
base/scoped_observer.h:32: // Removse the object passed to the constructor as an
observer from |source|.
On 2012/10/05 16:00:31, jar wrote:
> nit: typo: removse --> removes

Done.

Expand Messages | Collapse Messages