Add Mojo types and service definitions for Background Sync API

content/child/background_sync/background_sync_type_converters.cc

Index: content/child/background_sync/background_sync_type_converters.cc
diff --git a/content/child/background_sync/background_sync_type_converters.cc b/content/child/background_sync/background_sync_type_converters.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3979a77bcc3f06530ba11bb82af3490a047e5c46
--- /dev/null
+++ b/content/child/background_sync/background_sync_type_converters.cc
@@ -0,0 +1,157 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/child/background_sync/background_sync_type_converters.h"

[jkarlin, 2015/04/27 18:25:11]

New line after this line

[iclelland, 2015/04/28 12:41:29]

Done.

+#include "base/logging.h"
+
+namespace mojo {
+
+// static
+blink::WebSyncRegistration::Periodicity
+    TypeConverter<blink::WebSyncRegistration::Periodicity,
+                  content::background_sync::SyncPeriodicity>::Convert(
+        content::background_sync::SyncPeriodicity input) {
+  blink::WebSyncRegistration::Periodicity result;
+
+  switch (input) {
+    case content::background_sync::SYNC_PERIODICITY_Periodic:
+      result = blink::WebSyncRegistration::PeriodicityPeriodic;
+      break;
+    case content::background_sync::SYNC_PERIODICITY_OneShot:
+      result = blink::WebSyncRegistration::PeriodicityOneShot;
+      break;
+  }

[jkarlin, 2015/04/27 18:25:10]

Since you have the switch, you should call NOTREACHED() in the event of an
invalid enum value. 

E.g.,

switch (input) {
     case content::background_sync::SYNC_PERIODICITY_Periodic:
       return blink::WebSyncRegistration::PeriodicityPeriodic;
     case content::background_sync::SYNC_PERIODICITY_OneShot:
       return blink::WebSyncRegistration::PeriodicityOneShot;
   }
NOTREACHED();
return blink::WebSyncRegistration::PeriodicityPeriodic;


Alternatively, you can use COMPILE_ASSERTs to verify that the enums are the same
and simply static_cast between them. This doesn't provide protection against
invalid values but has its own advantages (simplicity). It would require a _MAX
value for each enum so that you know that you've verified all of them. See
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...
for an example.

[iclelland, 2015/04/28 12:41:29]

I thought that the compiler flags always included -Wswitch, so there was no need
to assert at run time that all values were handled. It doesn't look like
NOTREACHED costs anything in a release build, though, so it can't hurt.
It looks like only one side needs to define _MAX -- in that example, WebSocket.h
*does not* define _MAX, but ppb_websocket.h *does*. As long as that's okay, then
I'll use the static cast instead.

[jkarlin, 2015/04/29 13:49:26]

-Wswitch doesn't protect against invalid values (outside the enumeration's
range) from being passed in.
I agree that WebSocket.h doesn't have a _MAX, but it should. Otherwise how can
you convert in both directions safely? 

+  return result;
+}
+
+// static
+content::background_sync::SyncPeriodicity
+    TypeConverter<content::background_sync::SyncPeriodicity,
+                  blink::WebSyncRegistration::Periodicity>::Convert(
+        blink::WebSyncRegistration::Periodicity input) {
+  content::background_sync::SyncPeriodicity result;
+  switch (input) {
+    case blink::WebSyncRegistration::PeriodicityPeriodic:
+      result = content::background_sync::SYNC_PERIODICITY_Periodic;
+      break;
+    case blink::WebSyncRegistration::PeriodicityOneShot:
+      result = content::background_sync::SYNC_PERIODICITY_OneShot;
+      break;
+  }
+  return result;

[jkarlin, 2015/04/27 18:25:10]

ditto

[iclelland, 2015/04/28 12:41:29]

Done.

+}
+
+// static
+blink::WebSyncRegistration::NetworkState
+    TypeConverter<blink::WebSyncRegistration::NetworkState,
+                  content::background_sync::SyncNetworkState>::Convert(
+        content::background_sync::SyncNetworkState input) {
+  blink::WebSyncRegistration::NetworkState result;
+
+  switch (input) {
+    case content::background_sync::SYNC_NETWORK_STATE_Any:
+      result = blink::WebSyncRegistration::NetworkStateAny;
+      break;
+    case content::background_sync::SYNC_NETWORK_STATE_AvoidCellular:
+      result = blink::WebSyncRegistration::NetworkStateAvoidCellular;
+      break;
+    case content::background_sync::SYNC_NETWORK_STATE_Online:
+      result = blink::WebSyncRegistration::NetworkStateOnline;
+      break;
+  }
+  return result;

[jkarlin, 2015/04/27 18:25:11]

ditto

[iclelland, 2015/04/28 12:41:29]

Done.

+}
+
+// static
+content::background_sync::SyncNetworkState
+    TypeConverter<content::background_sync::SyncNetworkState,
+                  blink::WebSyncRegistration::NetworkState>::Convert(
+        blink::WebSyncRegistration::NetworkState input) {
+  content::background_sync::SyncNetworkState result;
+  switch (input) {
+    case blink::WebSyncRegistration::NetworkStateAny:
+      result = content::background_sync::SYNC_NETWORK_STATE_Any;
+      break;
+    case blink::WebSyncRegistration::NetworkStateAvoidCellular:
+      result = content::background_sync::SYNC_NETWORK_STATE_AvoidCellular;
+      break;
+    case blink::WebSyncRegistration::NetworkStateOnline:
+      result = content::background_sync::SYNC_NETWORK_STATE_Online;
+      break;
+  }
+  return result;

[jkarlin, 2015/04/27 18:25:11]

ditto

[iclelland, 2015/04/28 12:41:29]

Done.

+}
+
+// static
+blink::WebSyncRegistration::PowerState
+    TypeConverter<blink::WebSyncRegistration::PowerState,
+                  content::background_sync::SyncPowerState>::Convert(
+        content::background_sync::SyncPowerState input) {
+  blink::WebSyncRegistration::PowerState result;
+
+  switch (input) {
+    case content::background_sync::SYNC_POWER_STATE_Auto:
+      result = blink::WebSyncRegistration::PowerStateAuto;
+      break;
+    case content::background_sync::SYNC_POWER_STATE_AvoidDraining:
+      result = blink::WebSyncRegistration::PowerStateAvoidDraining;
+      break;
+  }
+  return result;
+}
+
+// static
+content::background_sync::SyncPowerState
+    TypeConverter<content::background_sync::SyncPowerState,
+                  blink::WebSyncRegistration::PowerState>::Convert(
+        blink::WebSyncRegistration::PowerState input) {
+  content::background_sync::SyncPowerState result;
+  switch (input) {
+    case blink::WebSyncRegistration::PowerStateAuto:
+      result = content::background_sync::SYNC_POWER_STATE_Auto;
+      break;
+    case blink::WebSyncRegistration::PowerStateAvoidDraining:
+      result = content::background_sync::SYNC_POWER_STATE_AvoidDraining;
+      break;
+  }
+  return result;

[jkarlin, 2015/04/27 18:25:11]

ditto

[iclelland, 2015/04/28 12:41:29]

Done.

+}
+
+// static
+blink::WebSyncRegistration* TypeConverter<blink::WebSyncRegistration *,

[jkarlin, 2015/04/27 18:25:10]

This naked pointer scares me. Return a scoped_ptr<blink::WebSyncRegistration>
instead.

[iclelland, 2015/04/28 12:41:29]

Done.

+     content::background_sync::SyncRegistrationPtr>::Convert(
+         const content::background_sync::SyncRegistrationPtr& input) {
+  blink::WebSyncRegistration* result = new blink::WebSyncRegistration();
+  result->id = input->id;
+  result->periodicity =
+      ConvertTo<blink::WebSyncRegistration::Periodicity>(input->periodicity);
+  result->tag = blink::WebString::fromUTF8(input->tag);
+  result->minPeriodMs = input->minPeriodMs;
+  result->networkState =
+      ConvertTo<blink::WebSyncRegistration::NetworkState>(input->networkState);
+  result->powerState =
+      ConvertTo<blink::WebSyncRegistration::PowerState>(input->powerState);
+  return result;
+}
+
+// static
+content::background_sync::SyncRegistrationPtr TypeConverter<
+    content::background_sync::SyncRegistrationPtr,
+    blink::WebSyncRegistration>::Convert(
+        const blink::WebSyncRegistration& input) {
+  content::background_sync::SyncRegistrationPtr result(
+      content::background_sync::SyncRegistration::New());
+  result->id = input.id;
+  result->periodicity =
+      ConvertTo<content::background_sync::SyncPeriodicity>(input.periodicity);
+  result->tag = input.tag.utf8();
+  result->minPeriodMs = input.minPeriodMs;
+  result->networkState =
+      ConvertTo<content::background_sync::SyncNetworkState>(input.networkState);
+  result->powerState =
+      ConvertTo<content::background_sync::SyncPowerState>(input.powerState);
+  return result.Pass();
+}
+
+} // namespace mojo

[jkarlin, 2015/04/27 18:25:11]

two spaces after }

[iclelland, 2015/04/28 12:41:29]

Done.