Add Mojo types and service definitions for Background Sync API

content/common/background_sync.mojom

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module content.background_sync;

[jkarlin, 2015/04/27 18:25:11]

I'd remove the namespace, and see comments below about naming the enums.

[iclelland, 2015/04/28 12:41:30]

Done.

+
+enum SyncNetworkState {
+  Any,
+  AvoidCellular,
+  Online,

[jkarlin, 2015/04/27 18:25:11]

These files are in chromium code and should use chromium style guide.

Suggest:

SYNC_NETWORK_STATE_ANY, SYNC_NETWORK_STATE_AVOID_CELLULAR,
SYNC_NETWORK_STATE_ONLINE

MACRO_CASE is required for Chromium enums and expanding the name is better in
the namespace. This also won't collide with the proto enums.

[iclelland, 2015/04/28 12:41:30]

The mojo bindings generator already prefixes these with "SYNC_NETWORK_STATE_",
because of the enum name. I'll uppercase the values to complete these, and
update the corresponding code everywhere.

The proto enums collide with the type name, not the enum values. It was
"SyncNetworkState" that was the issue when I included both headers.

I'm changing the enums to be named BackgroundSyncNetworkState, etc., and the
values will look like BACKGROUND_SYNC_NETWORK_STATE_ANY. This lets me remove the
extra namespace, and clean up code elsewhere.

+};
+
+enum SyncPowerState {
+  Auto,
+  AvoidDraining,

[jkarlin, 2015/04/27 18:25:11]

SYNC_POWER_STATE_AUTO and SYNC_POWER_STATE_DRAINING

[iclelland, 2015/04/28 12:41:30]

Done, as noted above (BACKGROUND_SYNC_POWER_STATE_AUTO, etc).

+};
+
+enum SyncPeriodicity {
+  Periodic,

[jkarlin, 2015/04/27 18:25:11]

SYNC_PERIODICITY_PERIODIC and SYNC_PERIODICITY_ONE_SHOT

[iclelland, 2015/04/28 12:41:30]

Done, as noted above (BACKGROUND_SYNC_PERIODICITY_PERIODIC, etc).

+  OneShot,
+};
+
+struct SyncRegistration {
+  int64 id = -1;
+  SyncPeriodicity periodicity = OneShot;
+  string tag = "";
+  uint64 minPeriodMs = 0;

[jkarlin, 2015/04/27 18:25:11]

min_period_ms

[iclelland, 2015/04/28 12:41:30]

Done.

+  SyncNetworkState networkState = Online;

[jkarlin, 2015/04/27 18:25:11]

network_state

[iclelland, 2015/04/28 12:41:30]

Done.

+  SyncPowerState powerState = Auto;

[jkarlin, 2015/04/27 18:25:11]

power_state

[iclelland, 2015/04/28 12:41:30]

Done.

+};