Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1106183007: Convert bitfields to bool in SelectorChecker. (Closed)

Created:
5 years, 7 months ago by esprehn
Modified:
5 years, 7 months ago
Reviewers:
pdr., Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert bitfields to bool in SelectorChecker. These objects are always created on the stack, and we only ever create at most depth of the tree of them so we don't need to save a couple bytes using a bitfield. The bitfield also means we end up doing extra bit operations every time we read. R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/core/css/SelectorChecker.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
5 years, 7 months ago (2015-04-28 23:31:35 UTC) #2
pdr.
LGTM
5 years, 7 months ago (2015-04-29 00:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106183007/1
5 years, 7 months ago (2015-04-29 00:29:39 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 01:50:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194641

Powered by Google App Engine
This is Rietveld 408576698