Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1106183006: Added gcdPrivate.getDeviceInfo function (Closed)

Created:
5 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_establish
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added gcdPrivate.getDeviceInfo function GCD App needs to query devices for basic information. BUG=brillo:839 Committed: https://crrev.com/cd4ff3af3ba883510a0fe1f802c35210c44247cb Cr-Commit-Position: refs/heads/master@{#327343}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Mon Apr 27 18:11:49 PDT 2015 #

Patch Set 3 : Mon Apr 27 18:15:08 PDT 2015 #

Patch Set 4 : Mon Apr 27 22:56:49 PDT 2015 #

Messages

Total messages: 19 (7 generated)
Vitaly Buka (NO REVIEWS)
PTAL
5 years, 7 months ago (2015-04-27 23:22:03 UTC) #2
not at google - send to devlin
IDL lgtm
5 years, 7 months ago (2015-04-27 23:40:35 UTC) #3
Aleksey Shlyapnikov
lgtm
5 years, 7 months ago (2015-04-27 23:54:31 UTC) #4
mednik
https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl File chrome/common/extensions/api/gcd_private.idl (right): https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl#newcode89 chrome/common/extensions/api/gcd_private.idl:89: // Called when the device info is availible or ...
5 years, 7 months ago (2015-04-28 00:35:40 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl File chrome/common/extensions/api/gcd_private.idl (right): https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl#newcode91 chrome/common/extensions/api/gcd_private.idl:91: // |deviceInfo| : Content of /privet/info response. On 2015/04/28 ...
5 years, 7 months ago (2015-04-28 00:37:52 UTC) #8
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl File chrome/common/extensions/api/gcd_private.idl (right): https://codereview.chromium.org/1106183006/diff/1/chrome/common/extensions/api/gcd_private.idl#newcode89 chrome/common/extensions/api/gcd_private.idl:89: // Called when the device info is availible or ...
5 years, 7 months ago (2015-04-28 01:13:21 UTC) #9
Vitaly Buka (NO REVIEWS)
+asvitkine for extensions\browser\extension_function_histogram_value.h
5 years, 7 months ago (2015-04-28 01:14:19 UTC) #11
Vitaly Buka (NO REVIEWS)
+asvitkine for extensions\browser\extension_function_histogram_value.h
5 years, 7 months ago (2015-04-28 01:16:47 UTC) #13
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-04-28 14:30:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106183006/60001
5 years, 7 months ago (2015-04-28 18:11:07 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-04-28 19:00:58 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 19:01:54 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cd4ff3af3ba883510a0fe1f802c35210c44247cb
Cr-Commit-Position: refs/heads/master@{#327343}

Powered by Google App Engine
This is Rietveld 408576698