Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1106173003: Uma stats for Data Saver prompt (Closed)

Created:
5 years, 7 months ago by Greg Levin
Modified:
5 years, 7 months ago
Reviewers:
stevenjb, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uma stats for Data Saver prompt BUG=475194 Collects UMA stats for (i) how many times the Data Saver prompt (notification) is shown, and (ii) how many times the Data Saver prompt is clicked on. Committed: https://crrev.com/d59a713c17b430a73695e1104139c9d396cc418b Cr-Commit-Position: refs/heads/master@{#327490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/chromeos/status/data_promo_notification.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Greg Levin
stevenjb: data_promo_notification.cc jwd: actions.xml Please have a look!
5 years, 7 months ago (2015-04-28 15:25:39 UTC) #2
jwd
Hey, I don't have a problem with these being logged as actions, but many of ...
5 years, 7 months ago (2015-04-28 18:10:45 UTC) #3
stevenjb
RecordAction is what we use for pretty much all UI events. We are generally only ...
5 years, 7 months ago (2015-04-28 23:03:43 UTC) #4
jwd
lgtm
5 years, 7 months ago (2015-04-29 14:17:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106173003/1
5 years, 7 months ago (2015-04-29 14:49:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 15:17:51 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:18:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d59a713c17b430a73695e1104139c9d396cc418b
Cr-Commit-Position: refs/heads/master@{#327490}

Powered by Google App Engine
This is Rietveld 408576698