Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1106173002: [DevTools] Fix crash on console input (Closed)

Created:
5 years, 8 months ago by vkuzkokov
Modified:
5 years, 8 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix crash on console input BUG=481127 Committed: https://crrev.com/f9cbf85d109b9d6a0af5ec5c761bc35535d8ee6b Cr-Commit-Position: refs/heads/master@{#327041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vkuzkokov
5 years, 8 months ago (2015-04-27 12:54:44 UTC) #2
dgozman
lgtm Andrey, should we merge this?
5 years, 8 months ago (2015-04-27 12:57:28 UTC) #3
lushnikov
On 2015/04/27 12:57:28, dgozman wrote: > lgtm > > Andrey, should we merge this? No ...
5 years, 8 months ago (2015-04-27 13:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106173002/1
5 years, 8 months ago (2015-04-27 13:54:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 14:39:53 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:40:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9cbf85d109b9d6a0af5ec5c761bc35535d8ee6b
Cr-Commit-Position: refs/heads/master@{#327041}

Powered by Google App Engine
This is Rietveld 408576698