SkPDF: clean up uses of deprecated calls in tests

SkPDF: clean up uses of deprecated calls in tests

BUG=skia:3585
Committed: https://skia.googlesource.com/skia/+/f7a169e225b6c5c7e79e14f6713256b4b8b9ab7f

[hal.canary, 2015-04-27 12:20:01]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-27 12:20:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106163002/1

[hal.canary, 2015-04-27 12:20:24]

halcanary@google.com changed reviewers:
+ tomhudson@chromium.org

[hal.canary, 2015-04-27 12:20:24]

PTAL

[commit-bot: I haz the power, 2015-04-27 12:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 12:23:56]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2015-04-27 18:41:37]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-04-27 18:41:38]

lgtm

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp
File tests/PDFPrimitivesTest.cpp (right):

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp...
tests/PDFPrimitivesTest.cpp:132: REPORTER_ASSERT(reporter,
catalog.getObjectNumber(a1.get()) == 1);
With the loss of int1Again, it looks like this isn't quite testing the same
thing any more?

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp...
tests/PDFPrimitivesTest.cpp:135: static void TestObjectRef(skiatest::Reporter*
reporter) {
Nit: it's hard to see how this test is testing ObjectRef. If the code can't be
clearer, can it get a 2-line comment?

[hal.canary, 2015-04-28 03:48:42]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2015-04-28 03:51:03]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2015-04-28 03:52:57]

In addition to the nits you made, I added a lot of tests and re-organized the
unit test.  I now have nearly 100% coverage of SkPDFTypes.

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp
File tests/PDFPrimitivesTest.cpp (right):

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp...
tests/PDFPrimitivesTest.cpp:132: REPORTER_ASSERT(reporter,
catalog.getObjectNumber(a1.get()) == 1);
On 2015/04/27 18:41:37, tomhudson wrote:
> With the loss of int1Again, it looks like this isn't quite testing the same
> thing any more?

int1Again.get() == int1.get(), so all it tested was that repeated calls to the
catalog returned the same thing.

https://codereview.chromium.org/1106163002/diff/1/tests/PDFPrimitivesTest.cpp...
tests/PDFPrimitivesTest.cpp:135: static void TestObjectRef(skiatest::Reporter*
reporter) {
On 2015/04/27 18:41:37, tomhudson wrote:
> Nit: it's hard to see how this test is testing ObjectRef. If the code can't be
> clearer, can it get a 2-line comment?

// If appendObjRef misbehaves, then the result would be [[]], not [1 0 R].

[hal.canary, 2015-05-01 11:46:40]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-05-01 11:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1106163002/#ps60001
(title: "2015-04-27 (Monday) 23:50:40 EDT")

[commit-bot: I haz the power, 2015-05-01 11:46:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106163002/60001

[commit-bot: I haz the power, 2015-05-01 12:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 12:00:57]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2015-05-01 14:32:16]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-05-01 14:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1106163002/#ps80001
(title: "2015-05-01 (Friday) 10:31:59 EDT")

[commit-bot: I haz the power, 2015-05-01 14:32:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106163002/80001

[commit-bot: I haz the power, 2015-05-01 14:35:48]

Committed patchset #3 (id:80001) as
https://skia.googlesource.com/skia/+/f7a169e225b6c5c7e79e14f6713256b4b8b9ab7f