Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1106003002: Add 'gn help grammar' contents to 'gn help all'. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'gn help grammar' contents to 'gn help all'. R=mdempsky@chromium.org BUG=468851 Committed: https://crrev.com/e7678ebda44587a7855835700aeeb9ccc846a1d9 Cr-Commit-Position: refs/heads/master@{#326905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
M tools/gn/command_help.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/docs/reference.md View 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-24 18:46:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106003002/1
5 years, 8 months ago (2015-04-24 18:46:50 UTC) #3
mdempsky
lgtm
5 years, 8 months ago (2015-04-24 18:56:16 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/58968)
5 years, 8 months ago (2015-04-24 19:58:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106003002/1
5 years, 8 months ago (2015-04-24 20:31:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/59034)
5 years, 8 months ago (2015-04-24 21:44:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106003002/1
5 years, 8 months ago (2015-04-24 21:53:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 22:24:57 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:27:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7678ebda44587a7855835700aeeb9ccc846a1d9
Cr-Commit-Position: refs/heads/master@{#326905}

Powered by Google App Engine
This is Rietveld 408576698