Pop up the notification when the download is interrupted or completed

chrome/browser/download/notification/download_notification_item.cc

Index: chrome/browser/download/notification/download_notification_item.cc
diff --git a/chrome/browser/download/notification/download_notification_item.cc b/chrome/browser/download/notification/download_notification_item.cc
index 759d75ca6760d4cb47c865d160147711c63abbe6..2f7d55201069aa0a02c372b7a680ebe7930272e7 100644
--- a/chrome/browser/download/notification/download_notification_item.cc
+++ b/chrome/browser/download/notification/download_notification_item.cc
@@ -186,7 +186,8 @@ void DownloadNotificationItem::UpdateNotificationData() {
         }
         break;
       case content::DownloadItem::COMPLETE:
-        notification_->set_type(message_center::NOTIFICATION_TYPE_SIMPLE);
+        notification_->set_type(message_center::NOTIFICATION_TYPE_PROGRESS);
+        notification_->set_progress(100);

[asanka, 2015/04/28 22:36:40]

Isn't the progress and type already correct at this point? It seems redundant to
set it here.

Perhaps DCHECK instead?

This is more of a UI question, but shouldn't the appearance of the notification
change after completion?

[yoshiki, 2015/05/12 14:49:33]

No. As for progress, before here, the progress, which has been set in the
previous call (STATE == IN_PROGRESS), is almost 100% but not 100%. We need to
set it to just 100%.

And I think it's better to set them here for downloads which is finished in a
very short time.
Done.
Sorry for lacking word, it's a kind of workaround for message center. As I wrote
in the comment, the content in non-progress notification is not updated when the
message center is visible, so we need to upload the notification once with type
== PROGRESS.

And I also updated the CL to remove and re-show the notification (patch set #4).

The new behavior is summarized as follows:
  step 1) Update with type=progress, progress=100% -> updated immediately
  step 2) Remove -> might be delayed when message center is visible
  step 3) Add -> might be delayed when message center is visible

         if (is_off_the_record) {
           // TODO(yoshiki): Replace the tentative image.
           SetNotificationImage(IDR_DOWNLOAD_NOTIFICATION_INCOGNITO);